Skip to content

Commit a10c442

Browse files
sparsi17claude
andauthored
refactor: Consolidate GCPCLOUDRUNREVISION into existing GCPRUNREVISION (#3037)
The GCPCLOUDRUNREVISION entity type was added recently but duplicates the pre-existing GCPRUNREVISION type used for GCP Cloud Run revisions. Consolidate by: - Deleting entity-types/infra-gcpcloudrunrevision/ entirely (definition.yml, golden_metrics.yml, summary_metrics.yml, dashboard.json). - Adding golden_metrics.yml and summary_metrics.yml under entity-types/infra-gcprunrevision/, copied verbatim from the deleted cloudrun folder (queries reference gcp.run.* metrics which are entity- type-agnostic). - Extending entity-types/infra-gcprunrevision/definition.yml with the goldenTags block ([gcp.projectId, gcp.region]) that was on the deleted definition; type key stays GCPRUNREVISION. Downstream (gcp-polling-v2 synthesis, infra-summary templates, UI definitions) must also point at GCPRUNREVISION instead of the removed GCPCLOUDRUNREVISION. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent e92dca0 commit a10c442

5 files changed

Lines changed: 3 additions & 197 deletions

File tree

entity-types/infra-gcpcloudrunrevision/dashboard.json

Lines changed: 0 additions & 186 deletions
This file was deleted.

entity-types/infra-gcpcloudrunrevision/definition.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

entity-types/infra-gcprunrevision/definition.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
domain: INFRA
22
type: GCPRUNREVISION
3+
goldenTags:
4+
- gcp.projectId
5+
- gcp.region
36
configuration:
47
entityExpirationTime: DAILY
58
alertable: true

entity-types/infra-gcpcloudrunrevision/golden_metrics.yml renamed to entity-types/infra-gcprunrevision/golden_metrics.yml

File renamed without changes.

entity-types/infra-gcpcloudrunrevision/summary_metrics.yml renamed to entity-types/infra-gcprunrevision/summary_metrics.yml

File renamed without changes.

0 commit comments

Comments
 (0)