Tech debt Changes and Ubuntu 16.04 support (#205)

Author: sanathramesh

.github/workflows/merge_to_main.yml

@@ -103,6 +103,17 @@ jobs:
     needs: [ get_release_tag, promote_prerelease_to_release ]
     if: ${{ needs.promote_prerelease_to_release.outputs.is_release == 'true' }}
     steps:
+      - name: Fetch artifacts
+        id: fetch_artifacts
+        run: |
+          RELEASE_ID=$(curl -s -H "Accept: application/vnd.github.v3+json" "https://api.github.com/repos/newrelic/fluent-bit-package/releases" | jq --arg tag "${{ needs.get_release_tag.outputs.tag }}" '.[] | select(.tag_name==$tag) | .id')
+          if [ -z "$RELEASE_ID" ]; then
+            echo "Failed to retrieve release ID"
+            exit 1
+          fi
+          ARTIFACTS=$(curl -s -H "Accept: application/vnd.github.v3+json" "https://api.github.com/repos/newrelic/fluent-bit-package/releases/$RELEASE_ID/assets" | jq -r '[.[] | select(.name | test("^(fb|fluent-bit)")) | .name] | join("\n")')
+          echo "artifacts=$ARTIFACTS" >> "$GITHUB_OUTPUT"
+
       - name: Send release details to Slack workflow
         id: slack
         uses: slackapi/slack-github-action@v1
@@ -112,7 +123,8 @@ jobs:
               "releaseUrl": "https://github.com/newrelic/fluent-bit-package/releases/tag/${{ needs.get_release_tag.outputs.tag }}",
               "releaseName": "${{ needs.get_release_tag.outputs.tag }}",
               "productName": "${{ env.PRODUCT_NAME }}",
-              "productUrl": "${{ env.PRODUCT_URL }}"
+              "productUrl": "${{ env.PRODUCT_URL }}",
+              "publishedPackages" : "${{ steps.fetch_artifacts.outputs.artifacts }}"
             }
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

.github/workflows/pull_request.yml

@@ -24,6 +24,7 @@ jobs:
       sles_matrix: ${{ steps.set-matrices.outputs.sles_matrix }}
       linux_and_windows_matrix: ${{ steps.set-matrices.outputs.linux_and_windows_matrix }}
       linux_and_windows_unique_target_package : ${{ steps.set-matrices.outputs.linux_and_windows_unique_target_package }}
+      windows_matrix: ${{ steps.set-matrices.outputs.windows_matrix }}
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
@@ -70,6 +71,7 @@ jobs:
           filtered_json=$(echo "$json_data" | jq 'unique_by(.targetPackageName)')
           echo "linux_and_windows_unique_target_package=$(echo $filtered_json)" >> "$GITHUB_OUTPUT"
           echo "sles_matrix=$( cat versions/slesMatrix.json )" >> "$GITHUB_OUTPUT"
+          echo "windows_matrix=$( cat versions/windowsMatrix.json )" >> "$GITHUB_OUTPUT"
           gh release upload ${{ env.PRE_RELEASE_NAME }} versions/linuxAndWindowsMatrix.json --repo newrelic/fluent-bit-package
           gh release upload ${{ env.PRE_RELEASE_NAME }} versions/slesMatrix.json --repo newrelic/fluent-bit-package
 
@@ -158,6 +160,7 @@ jobs:
       infra_agent_env: prerelease
       sles_matrix: ${{ needs.setup_environment.outputs.sles_matrix }}
       pre_release_name: ${{ needs.setup_environment.outputs.pre_release_name }}
+      windows_matrix: ${{ needs.setup_environment.outputs.windows_matrix }}
     secrets: inherit
 
   publish_linux_to_staging:

.github/workflows/run_prerelease.yml

@@ -27,6 +27,10 @@ on:
         description: Matrix of SLES distros, versions, and architectures to run the tests on
         required: false
         type: string
+      windows_matrix:
+        description: Matrix of Windows distros, versions, and architectures to run the tests on
+        required: false
+        type: string
       linux_test_report_name:
         description: Linux test report name
         required: false
@@ -62,6 +66,10 @@ on:
         description: Matrix of SLES distros, versions, and architectures to run the tests on
         required: false
         type: string
+      windows_matrix:
+        description: Matrix of Windows distros, versions, and architectures to run the tests on
+        required: false
+        type: string
       linux_test_report_name:
         description: Linux test report name
         required: false
@@ -102,14 +110,14 @@ jobs:
     secrets: inherit
 
   build_suse_packages:
-    needs: [spin_up_suse ]
+    needs: [ spin_up_suse ]
     uses: ./.github/workflows/run_task.yml
     with:
       container_make_target: "ansible/build-fb-suse/run PRE_RELEASE_NAME=${{ inputs.pre_release_name }}"
     secrets: inherit
 
   tear_down_suse:
-    needs: [build_suse_packages ]
+    needs: [ build_suse_packages ]
     if: always()
     uses: ./.github/workflows/run_task.yml
     with:
@@ -144,10 +152,12 @@ jobs:
         run:
           gh release upload ${{ inputs.pre_release_name }} packages/* --clobber
 
-
   provision_and_execute_tests_linux:
-    name: Provision instances and run tests for linux
-    needs: [spin_up_test_executor_instances, sign_suse_packages, tear_down_suse]
+    name:  Provision instances and run tests for linux
+    needs: [ spin_up_test_executor_instances, sign_suse_packages, tear_down_suse ]
+    if: ${{ always() && !failure() && !cancelled()
+      && (needs.spin_up_test_executor_instances.result == 'success' || needs.spin_up_test_executor_instances.result == 'skipped')
+      && (needs.sign_suse_packages.result == 'success' || needs.sign_suse_packages.result == 'skipped')}}
     uses: ./.github/workflows/run_task.yml
     with:
       container_make_target: "ansible/provision-and-execute-tests/${{ inputs.infra_agent_env }}-linux PRE_RELEASE_NAME=${{ inputs.gh_release_name }} TEST_REPORT_NAME=${{ inputs.linux_test_report_name }}"
@@ -156,15 +166,17 @@ jobs:
   provision_and_execute_tests_windows:
     name: Provision instances and run tests for windows
     needs: spin_up_test_executor_instances
+    if: ${{ (needs.spin_up_test_executor_instances.result == 'success' || needs.spin_up_test_executor_instances.result == 'skipped') && ( inputs.windows_matrix != '[]' ) }}
     uses: ./.github/workflows/run_task.yml
     with:
       container_make_target: "ansible/provision-and-execute-tests/${{ inputs.infra_agent_env }}-windows PRE_RELEASE_NAME=${{ inputs.gh_release_name }} TEST_REPORT_NAME=${{ inputs.windows_test_report_name }}"
     secrets: inherit
 
   report_linux_test_results:
-    name: Report results
+    name: Report results linux
     runs-on: ubuntu-20.04
     needs: [ provision_and_execute_tests_linux ]
+    if : ${{ always() && !failure() && !cancelled() && (needs.provision_and_execute_tests_linux.result == 'success')}}
     env:
       GH_TOKEN: ${{ github.token }}
     steps:
@@ -190,9 +202,10 @@ jobs:
             ${{ inputs.linux_test_report_name }}
 
   report_windows_test_results:
-    name: Report results
+    name: Report results windows
     runs-on: ubuntu-20.04
-    needs: [provision_and_execute_tests_windows ]
+    needs: [ provision_and_execute_tests_windows ]
+    if: ${{ inputs.windows_matrix != '[]' }}
     env:
       GH_TOKEN: ${{ github.token }}
     steps:
@@ -220,7 +233,7 @@ jobs:
   tear_down_test_executor_instances:
     name: Tear down test executor instances
     if: always()
-    needs: [report_windows_test_results, report_linux_test_results]
+    needs: [ report_windows_test_results, report_linux_test_results ]
     uses: ./.github/workflows/run_task.yml
     with:
       container_make_target: "terraform/ec2-test-executors/clean PRE_RELEASE_NAME=${{ inputs.gh_release_name }}"

versions/ubuntu_16_xenial.yml

@@ -0,0 +1,5 @@
+osDistro: ubuntu
+osVersion: xenial
+packages:
+  - arch: amd64
+    ami: ami-01e7407a20284c7ff

versions/windows-server-2019.yml

@@ -2,7 +2,7 @@ osDistro: windows-server
 osVersion: 2019
 packages:
   - arch: win64
-    ami: ami-033cf42b9fd3b1b94
+    ami: ami-00144397b84c851bd
   # There is no win32 image available in AWS, so we use the w64 one to test the w32 binaries
   - arch: win32
-    ami: ami-033cf42b9fd3b1b94
+    ami: ami-00144397b84c851bd