Skip to content

Commit 17ea85c

Browse files
authored
fix: service names should be dynamic (#1958)
Service names should be unique per Helm release by default. Otherwise, the user needs to know to override the hostname values.
1 parent ea8624e commit 17ea85c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

charts/synthetics-job-manager/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: synthetics-job-manager
33
description: New Relic Synthetics Containerized Job Manager
44
type: application
5-
version: 3.0.37
5+
version: 3.0.38
66
appVersion: release-471
77
home: https://github.com/orgs/newrelic/teams/proactive-monitoring
88
maintainers:

charts/synthetics-job-manager/templates/_helpers.tpl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,16 @@ Allows to override the appVersion to use.
4141
Allows overriding of the synthetics-job-manager Service hostname
4242
*/}}
4343
{{- define "synthetics-job-manager.hostname" -}}
44-
{{- default "synthetics-job-manager" .Values.global.hostnameOverride | trunc 63 | trimSuffix "-" }}
44+
{{- $name := default "synthetics-job-manager" (index .Values "global" "hostnameOverride") -}}
45+
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
4546
{{- end }}
4647

4748
{{/*
48-
Allows overriding of the ping-runtime Service hostname
49+
Allows overriding of the ping-runtime Service hostname, making it unique per release
4950
*/}}
5051
{{- define "ping-runtime.hostname" -}}
51-
{{- default "ping" (index .Values "global" "ping-runtime" "hostnameOverride") | trunc 63 | trimSuffix "-" }}
52+
{{- $name := default "ping" (index .Values "global" "ping-runtime" "hostnameOverride") -}}
53+
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
5254
{{- end }}
5355

5456
{{/*

0 commit comments

Comments
 (0)