Skip to content

Commit 2d63601

Browse files
authored
fix: remove filters dropping critical cpu, memory, and k8s state metrics (#2078)
<!-- Thank you for contributing to New Relic's Helm charts. Before you submit this PR we'd like to make sure you are aware of our technical requirements: * https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements For a quick overview across what we will look at reviewing your PR, please read our review guidelines: * https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md Following our best practices right from the start will accelerate the review process and help get your PR merged quicker. When updates to your PR are requested, please add new commits and do not squash the history. This will make it easier to identify new changes. The PR will be squashed anyways when it is merged. Thanks. For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file. Please make sure you test your changes before you push them. Once pushed, a Github Action will run across your changes and do some initial checks and linting. These checks run very quickly. Please check the results. We would like these checks to pass before we even continue reviewing your changes. --> #### What this PR does / why we need it: remove some filters to enable the collection of certain data that is critical for the functionality of certain important dashboards. #### Which issue this PR fixes https://new-relic.atlassian.net/browse/NR-510732?actionerId=712020%3A4f8442e8-7591-4845-bfe0-8f5e6f27b98f&sourceType=assign #### Special notes for your reviewer: #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.] - [ ] Chart Version bumped - [ ] Variables are documented in the README.md - [ ] Title of the PR starts with chart name (e.g. `[mychartname]`) # Release Notes to Publish (nr-k8s-otel-collector) If this PR contains changes in `nr-k8s-otel-collector`, please complete the following section. All other charts should ignore this section. <!--BEGIN-RELEASE-NOTES--> ## 🚀 What's Changed * Removed filters dropping critical cpu, memory, and k8s state metrics <!--END-RELEASE-NOTES-->
1 parent 14a36dd commit 2d63601

File tree

12 files changed

+15
-129
lines changed

12 files changed

+15
-129
lines changed

charts/nr-k8s-otel-collector/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ type: application
1717
# This is the chart version. This version number should be incremented each time you make changes
1818
# to the chart and its templates, including the app version.
1919
# Versions are expected to follow Semantic Versioning (https://semver.org/)
20-
version: 0.10.1
20+
version: 0.10.2
2121

2222

2323
dependencies:

charts/nr-k8s-otel-collector/examples/k8s/rendered/clusterrole.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ metadata:
99
app.kubernetes.io/managed-by: Helm
1010
app.kubernetes.io/name: nr-k8s-otel-collector
1111
app.kubernetes.io/version: 1.2.0
12-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
12+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1313
rules:
1414
- apiGroups:
1515
- ""

charts/nr-k8s-otel-collector/examples/k8s/rendered/clusterrolebinding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ metadata:
99
app.kubernetes.io/managed-by: Helm
1010
app.kubernetes.io/name: nr-k8s-otel-collector
1111
app.kubernetes.io/version: 1.2.0
12-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
12+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1313
subjects:
1414
- kind: ServiceAccount
1515
name: nr-k8s-otel-collector

charts/nr-k8s-otel-collector/examples/k8s/rendered/daemonset-configmap.yaml

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1414
data:
1515
daemonset-config.yaml: |
1616
receivers:
@@ -514,25 +514,6 @@ data:
514514
aggregation_type: sum
515515
516516
# following system.% metrics reduce metrics reported by hostmetrics receiver
517-
filter/exclude_cpu_utilization:
518-
metrics:
519-
datapoint:
520-
- 'metric.name == "system.cpu.utilization" and attributes["state"] == "interrupt"'
521-
- 'metric.name == "system.cpu.utilization" and attributes["state"] == "nice"'
522-
- 'metric.name == "system.cpu.utilization" and attributes["state"] == "softirq"'
523-
filter/exclude_memory_utilization:
524-
metrics:
525-
datapoint:
526-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "slab_unreclaimable"'
527-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "inactive"'
528-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "cached"'
529-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "buffered"'
530-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "slab_reclaimable"'
531-
filter/exclude_memory_usage:
532-
metrics:
533-
datapoint:
534-
- 'metric.name == "system.memory.usage" and attributes["state"] == "slab_unreclaimable"'
535-
- 'metric.name == "system.memory.usage" and attributes["state"] == "inactive"'
536517
filter/exclude_filesystem_utilization:
537518
metrics:
538519
datapoint:
@@ -607,7 +588,7 @@ data:
607588
value: <cluser_name>
608589
- key: "newrelic.chart.version"
609590
action: upsert
610-
value: 0.10.1
591+
value: 0.10.2
611592
- key: newrelic.entity.type
612593
action: upsert
613594
value: "k8s"
@@ -775,9 +756,6 @@ data:
775756
- filter/exclude_metrics_low_data_mode
776757
- metricstransform/hostmetrics_cpu
777758
- transform/truncate
778-
- filter/exclude_cpu_utilization
779-
- filter/exclude_memory_utilization
780-
- filter/exclude_memory_usage
781759
- filter/exclude_filesystem_utilization
782760
- filter/exclude_filesystem_usage
783761
- filter/exclude_filesystem_inodes_usage

charts/nr-k8s-otel-collector/examples/k8s/rendered/daemonset.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1414
spec:
1515
selector:
1616
matchLabels:
@@ -24,7 +24,7 @@ spec:
2424
app.kubernetes.io/name: nr-k8s-otel-collector
2525
component: daemonset
2626
annotations:
27-
checksum/config: 2fc676bab1a4717b68d104ea4926bbd8ee75c4697be5afb59a9e1421975a09e6
27+
checksum/config: 504fbfbe00f77ebec6de42ca8bdc9d2d3879a112da328c8549c0b167316755b8
2828
spec:
2929
serviceAccountName: nr-k8s-otel-collector
3030
initContainers:

charts/nr-k8s-otel-collector/examples/k8s/rendered/deployment-configmap.yaml

Lines changed: 3 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1414
data:
1515
deployment-config.yaml: |
1616
receivers:
@@ -477,37 +477,6 @@ data:
477477
metric:
478478
- 'HasAttrOnDatapoint("low.data.mode", "false")'
479479
480-
filter/exclude_zero_value_kube_node_status_condition:
481-
metrics:
482-
datapoint:
483-
- metric.name == "kube_node_status_condition" and value_double == 0.0
484-
485-
filter/exclude_zero_value_kube_persistentvolumeclaim_status_phase:
486-
metrics:
487-
datapoint:
488-
- metric.name == "kube_persistentvolumeclaim_status_phase" and value_double == 0.0
489-
490-
filter/nr_exclude_zero_value_kube_pod_container_deployment_statuses:
491-
metrics:
492-
datapoint:
493-
- metric.name == "kube_pod_status_phase" and value_double < 0.5
494-
- metric.name == "kube_pod_status_ready" and value_double < 0.5
495-
- metric.name == "kube_pod_status_scheduled" and value_double < 0.5
496-
- metric.name == "kube_pod_container_status_ready" and value_double < 0.5
497-
- metric.name == "kube_pod_container_status_phase" and value_double < 0.5
498-
- metric.name == "kube_pod_container_status_restarts_total" and value_double < 0.5
499-
- metric.name == "kube_deployment_status_condition" and value_double < 0.5
500-
- metric.name == "kube_pod_container_status_waiting_reason" and value_double < 0.5
501-
502-
filter/nr_exclude_zero_value_kube_jobs:
503-
metrics:
504-
datapoint:
505-
- metric.name == "kube_job_complete" and value_double < 0.5
506-
- metric.name == "kube_job_spec_parallelism" and value_double < 0.5
507-
- metric.name == "kube_job_status_failed" and value_double < 0.5
508-
- metric.name == "kube_job_status_active" and value_double < 0.5
509-
- metric.name == "kube_job_status_succeeded" and value_double < 0.5
510-
511480
resource/newrelic:
512481
attributes:
513482
# We set the cluster name to what the customer specified in the helm chart
@@ -516,7 +485,7 @@ data:
516485
value: <cluser_name>
517486
- key: "newrelic.chart.version"
518487
action: upsert
519-
value: 0.10.1
488+
value: 0.10.2
520489
- key: newrelic.entity.type
521490
action: upsert
522491
value: "k8s"
@@ -534,7 +503,7 @@ data:
534503
value: <cluser_name>
535504
- key: "newrelic.chart.version"
536505
action: upsert
537-
value: 0.10.1
506+
value: 0.10.2
538507
539508
transform/events:
540509
log_statements:
@@ -759,15 +728,11 @@ data:
759728
processors:
760729
- memory_limiter
761730
- metricstransform/kube_pod_container_status_phase
762-
- filter/exclude_zero_value_kube_node_status_condition
763-
- filter/exclude_zero_value_kube_persistentvolumeclaim_status_phase
764-
- filter/nr_exclude_zero_value_kube_pod_container_deployment_statuses
765731
- transform/convert_timestamp
766732
- metricstransform/ldm
767733
- metricstransform/k8s_cluster_info_ldm
768734
- metricstransform/ksm
769735
- filter/exclude_metrics_low_data_mode
770-
- filter/nr_exclude_zero_value_kube_jobs
771736
- transform/low_data_mode_inator
772737
- resource/low_data_mode_inator
773738
- resource/newrelic

charts/nr-k8s-otel-collector/examples/k8s/rendered/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1414
spec:
1515
replicas: 1
1616
minReadySeconds: 5
@@ -26,7 +26,7 @@ spec:
2626
app.kubernetes.io/name: nr-k8s-otel-collector
2727
component: deployment
2828
annotations:
29-
checksum/config: 1c56911b2943644694f4358b8ff53a07746aa92f019544bf2e3996a0e1097e28
29+
checksum/config: 6e1c518452cac5c5f56b2e6f16c1238fb18e6b3c0d5d6ba977dbe539e365ea47
3030
spec:
3131
serviceAccountName: nr-k8s-otel-collector
3232
containers:

charts/nr-k8s-otel-collector/examples/k8s/rendered/secret.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1414
data:
1515
licenseKey: PE5SX2xpY2Vuc2VLZXk+

charts/nr-k8s-otel-collector/examples/k8s/rendered/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1414
spec:
1515
type: ClusterIP
1616
ports:

charts/nr-k8s-otel-collector/examples/k8s/rendered/serviceaccount.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.1
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.2
1414
annotations:

0 commit comments

Comments
 (0)