Skip to content

Commit 523e176

Browse files
committed
Change deploymentName to cluster
1 parent d705ebf commit 523e176

File tree

7 files changed

+11
-11
lines changed

7 files changed

+11
-11
lines changed

charts/nr-ebpf-agent/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ A Helm chart to monitor a Kubernetes Cluster using the eBPF agent.
66

77
# Helm installation
88

9-
1. Download and modify the default configuration file [values.yaml](https://github.com/newrelic/helm-charts/blob/master/charts/nr-ebpf-agent/values.yaml#L1-L4). At minimum, you will need populate the `licenseKey` field with a valid New Relic Ingest key and the `deploymentName` field with the name of the cluster to monitor.
9+
1. Download and modify the default configuration file [values.yaml](https://github.com/newrelic/helm-charts/blob/master/charts/nr-ebpf-agent/values.yaml#L1-L4). At minimum, you will need populate the `licenseKey` field with a valid New Relic Ingest key and the `cluster` field with the name of the cluster to monitor.
1010

1111
**NOTE: From chart version 0.2.x onwards, please use the latest [values.yaml](https://github.com/newrelic/helm-charts/blob/master/charts/nr-ebpf-agent/values.yaml) bundled with each Helm release. This will ensure compatibility with new features and configuration options.**
1212

1313
Example:
1414
```
1515
licenseKey: "EXAMPLEINGESTLICENSEKEY345878592NRALL"
16-
deploymentName: "name-of-cluster-to-monitor"
16+
cluster: "name-of-cluster-to-monitor"
1717
```
1818

1919
2. Install the helm chart, passing the configuration file created above.
@@ -78,7 +78,7 @@ Options that can be defined globally include `affinity`, `nodeSelector`, `tolera
7878
|-----|------|---------|-------------|
7979
| affinity | object | `{}` | Sets all pods' affinities. Can be configured also with `global.affinity` |
8080
| allowServiceNameRegex | string | `""` | This config acts as a bypass for the dropDataServiceNameRegex config. Service names that match this regex will not have their data dropped by the dropDataServiceNameRegex. If dropDataServiceNameRegex is not defined, this config has no impact on the eBPF agent. |
81-
| deploymentName | string | `""` | Name of the Kubernetes cluster to be monitored. Mandatory. Can be configured with `global.deploymentName` |
81+
| cluster | string | `""` | Name of the Kubernetes cluster to be monitored. Mandatory. Can be configured with `global.cluster` |
8282
| containerSecurityContext | object | `{}` | Sets all pods' containerSecurityContext. Can be configured also with `global.securityContext.container` |
8383
| customSecretLicenseKey | string | `""` | In case you don't want to have the license key in your values, this allows you to point to which secret key is the license key located. Can be configured also with `global.customSecretLicenseKey` |
8484
| customSecretName | string | `""` | In case you don't want to have the license key in your values, this allows you to point to a user created secret to get the key from there. Can be configured also with `global.customSecretName` |

charts/nr-ebpf-agent/README.md.gotmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77

88
# Helm installation
99

10-
1. Download and modify the default configuration file [values.yaml](https://github.com/newrelic/helm-charts/blob/master/charts/nr-ebpf-agent/values.yaml#L1-L4). At minimum, you will need populate the `licenseKey` field with a valid New Relic Ingest key and the `deploymentName` field with the name of the cluster to monitor.
10+
1. Download and modify the default configuration file [values.yaml](https://github.com/newrelic/helm-charts/blob/master/charts/nr-ebpf-agent/values.yaml#L1-L4). At minimum, you will need populate the `licenseKey` field with a valid New Relic Ingest key and the `cluster` field with the name of the cluster to monitor.
1111

1212
Example:
1313
```
1414
licenseKey: "EXAMPLEINGESTLICENSEKEY345878592NRALL"
15-
deploymentName: "name-of-cluster-to-monitor"
15+
cluster: "name-of-cluster-to-monitor"
1616
```
1717

1818
2. Install the helm chart, passing the configuration file created above.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
deploymentName: "test-ebpf-agent-cluster"
1+
cluster: "test-ebpf-agent-cluster"
22
licenseKey: "1234567890abcdef1234567890abcdef12345678"

charts/nr-ebpf-agent/templates/_helpers.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Return the cluster name
4646
*/}}
4747
{{- define "nr-ebpf-agent.clusterName" -}}
4848
{{- if .Values.global }}
49-
{{- .Values.global.deploymentName | default "" -}}
49+
{{- .Values.global.cluster | default "" -}}
5050
{{- else -}}
5151
{{- "" -}}
5252
{{- end -}}

charts/nr-ebpf-agent/templates/nr-ebpf-agent-daemonset.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ spec:
8787
resources: {{ .Values.ebpfClient.resources | toYaml | nindent 10 }}
8888
env:
8989
- name: DEPLOYMENT_NAME
90-
value: {{ .Values.deploymentName }}
90+
value: {{ .Values.cluster }}
9191
- name: HOST_IP
9292
valueFrom:
9393
fieldRef:

charts/nr-ebpf-agent/templates/otel-collector-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,5 +257,5 @@ data:
257257
{{- if $globalClusterName}}
258258
clusterName: {{ $globalClusterName }}
259259
{{ else }}
260-
clusterName: {{ required "Please set the Kubernetes cluster name" .Values.deploymentName | quote }}
260+
clusterName: {{ required "Please set the Kubernetes cluster name" .Values.cluster | quote }}
261261
{{ end }}

charts/nr-ebpf-agent/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
# -- Name of the Kubernetes cluster to be monitored. Mandatory. Can be configured with `global.deploymentName`
3-
deploymentName: ""
2+
# -- Name of the Kubernetes cluster to be monitored. Mandatory. Can be configured with `global.cluster`
3+
cluster: ""
44
# -- The license key to use. Can be configured with `global.licenseKey`
55
licenseKey: ""
66
# -- In case you don't want to have the license key in your values, this allows you to point to a user created secret to get the key from there. Can be configured also with `global.customSecretName`

0 commit comments

Comments
 (0)