Skip to content

Commit 5c8d6dc

Browse files
authored
[nr-k8s-otel-collector] remove filters dropping critical cpu, memory, and k8s state metrics (#2126)
<!-- Thank you for contributing to New Relic's Helm charts. Before you submit this PR we'd like to make sure you are aware of our technical requirements: * https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements For a quick overview across what we will look at reviewing your PR, please read our review guidelines: * https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md Following our best practices right from the start will accelerate the review process and help get your PR merged quicker. When updates to your PR are requested, please add new commits and do not squash the history. This will make it easier to identify new changes. The PR will be squashed anyways when it is merged. Thanks. For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file. Please make sure you test your changes before you push them. Once pushed, a Github Action will run across your changes and do some initial checks and linting. These checks run very quickly. Please check the results. We would like these checks to pass before we even continue reviewing your changes. --> #### What this PR does / why we need it: Remove filters dropping critical cpu, memory, and k8s state metrics #### Which issue this PR fixes *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)* - fixes #510732 #### Special notes for your reviewer: #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.] - [x] Chart Version bumped - [x] Variables are documented in the README.md - [x] Title of the PR starts with chart name (e.g. `[mychartname]`) # Release Notes to Publish (nr-k8s-otel-collector) If this PR contains changes in `nr-k8s-otel-collector`, please complete the following section. All other charts should ignore this section. <!--BEGIN-RELEASE-NOTES--> ## 🚀 What's Changed * Removed filters dropping critical cpu, memory, and k8s state metrics <!--END-RELEASE-NOTES-->
1 parent d77e183 commit 5c8d6dc

21 files changed

+47
-134
lines changed

charts/nr-k8s-otel-collector/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ type: application
1717
# This is the chart version. This version number should be incremented each time you make changes
1818
# to the chart and its templates, including the app version.
1919
# Versions are expected to follow Semantic Versioning (https://semver.org/)
20-
version: 0.10.7
20+
version: 0.10.8
2121

2222

2323
dependencies:

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/clusterrole.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ metadata:
99
app.kubernetes.io/managed-by: Helm
1010
app.kubernetes.io/name: nr-k8s-otel-collector
1111
app.kubernetes.io/version: 1.2.0
12-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
12+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1313
rules:
1414
- apiGroups:
1515
- ""

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/clusterrolebinding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ metadata:
99
app.kubernetes.io/managed-by: Helm
1010
app.kubernetes.io/name: nr-k8s-otel-collector
1111
app.kubernetes.io/version: 1.2.0
12-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
12+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1313
subjects:
1414
- kind: ServiceAccount
1515
name: nr-k8s-otel-collector

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/daemonset-configmap.yaml

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1414
data:
1515
daemonset-config.yaml: |
1616
receivers:
@@ -544,25 +544,6 @@ data:
544544
aggregation_type: sum
545545
546546
# following system.% metrics reduce metrics reported by hostmetrics receiver
547-
filter/exclude_cpu_utilization:
548-
metrics:
549-
datapoint:
550-
- 'metric.name == "system.cpu.utilization" and attributes["state"] == "interrupt"'
551-
- 'metric.name == "system.cpu.utilization" and attributes["state"] == "nice"'
552-
- 'metric.name == "system.cpu.utilization" and attributes["state"] == "softirq"'
553-
filter/exclude_memory_utilization:
554-
metrics:
555-
datapoint:
556-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "slab_unreclaimable"'
557-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "inactive"'
558-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "cached"'
559-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "buffered"'
560-
- 'metric.name == "system.memory.utilization" and attributes["state"] == "slab_reclaimable"'
561-
filter/exclude_memory_usage:
562-
metrics:
563-
datapoint:
564-
- 'metric.name == "system.memory.usage" and attributes["state"] == "slab_unreclaimable"'
565-
- 'metric.name == "system.memory.usage" and attributes["state"] == "inactive"'
566547
filter/exclude_filesystem_utilization:
567548
metrics:
568549
datapoint:
@@ -637,7 +618,7 @@ data:
637618
value: <cluser_name>
638619
- key: "newrelic.chart.version"
639620
action: upsert
640-
value: 0.10.7
621+
value: 0.10.8
641622
- key: newrelic.entity.type
642623
action: upsert
643624
value: "k8s"
@@ -814,9 +795,6 @@ data:
814795
- filter/exclude_metrics_low_data_mode
815796
- metricstransform/hostmetrics_cpu
816797
- transform/truncate
817-
- filter/exclude_cpu_utilization
818-
- filter/exclude_memory_utilization
819-
- filter/exclude_memory_usage
820798
- filter/exclude_filesystem_utilization
821799
- filter/exclude_filesystem_usage
822800
- filter/exclude_filesystem_inodes_usage

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/daemonset.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1414
spec:
1515
selector:
1616
matchLabels:
@@ -24,7 +24,7 @@ spec:
2424
app.kubernetes.io/name: nr-k8s-otel-collector
2525
component: daemonset
2626
annotations:
27-
checksum/config: 1f1cff8b904a341d199e201ae3307759fc4369cffb15eeffb0e66e94484777d3
27+
checksum/config: fa6441edefae88d7fa03cc9fd4a8be40e40ea734040fc5cb6361f5a7130a002b
2828
spec:
2929
serviceAccountName: nr-k8s-otel-collector
3030
initContainers:

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/deployment-configmap.yaml

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1414
data:
1515
deployment-config.yaml: |
1616
receivers:
@@ -490,23 +490,16 @@ data:
490490
filter/nr_exclude_zero_value_kube_pod_container_deployment_statuses:
491491
metrics:
492492
datapoint:
493-
- metric.name == "kube_pod_status_phase" and value_double < 0.5
494-
- metric.name == "kube_pod_status_ready" and value_double < 0.5
495-
- metric.name == "kube_pod_status_scheduled" and value_double < 0.5
496-
- metric.name == "kube_pod_container_status_ready" and value_double < 0.5
497-
- metric.name == "kube_pod_container_status_phase" and value_double < 0.5
498-
- metric.name == "kube_pod_container_status_restarts_total" and value_double < 0.5
499-
- metric.name == "kube_deployment_status_condition" and value_double < 0.5
500-
- metric.name == "kube_pod_container_status_waiting_reason" and value_double < 0.5
493+
- metric.name == "kube_pod_status_phase" and value_double == 0.0
494+
- metric.name == "kube_pod_status_ready" and value_double == 0.0
495+
- metric.name == "kube_pod_status_scheduled" and value_double == 0.0
496+
- metric.name == "kube_pod_container_status_phase" and value_double == 0.0
497+
- metric.name == "kube_deployment_status_condition" and value_double == 0.0
501498
502499
filter/nr_exclude_zero_value_kube_jobs:
503500
metrics:
504501
datapoint:
505-
- metric.name == "kube_job_complete" and value_double < 0.5
506-
- metric.name == "kube_job_spec_parallelism" and value_double < 0.5
507-
- metric.name == "kube_job_status_failed" and value_double < 0.5
508-
- metric.name == "kube_job_status_active" and value_double < 0.5
509-
- metric.name == "kube_job_status_succeeded" and value_double < 0.5
502+
- metric.name == "kube_job_complete" and value_double == 0.0
510503
511504
resource/newrelic:
512505
attributes:
@@ -516,7 +509,7 @@ data:
516509
value: <cluser_name>
517510
- key: "newrelic.chart.version"
518511
action: upsert
519-
value: 0.10.7
512+
value: 0.10.8
520513
- key: newrelic.entity.type
521514
action: upsert
522515
value: "k8s"
@@ -534,7 +527,7 @@ data:
534527
value: <cluser_name>
535528
- key: "newrelic.chart.version"
536529
action: upsert
537-
value: 0.10.7
530+
value: 0.10.8
538531
539532
transform/events:
540533
log_statements:

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1414
spec:
1515
replicas: 1
1616
minReadySeconds: 5
@@ -26,7 +26,7 @@ spec:
2626
app.kubernetes.io/name: nr-k8s-otel-collector
2727
component: deployment
2828
annotations:
29-
checksum/config: 200e23524936cc269780cd8f198326d9e4b704203ea122499d1bebfe352aff11
29+
checksum/config: d38b8053af426b90b8ee9f7a683d00963f69800b375c423f523ab0256812267c
3030
spec:
3131
serviceAccountName: nr-k8s-otel-collector
3232
containers:

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/secret.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1414
data:
1515
licenseKey: PE5SX2xpY2Vuc2VLZXk+

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1414
spec:
1515
type: ClusterIP
1616
ports:

charts/nr-k8s-otel-collector/examples/k8s-with-atp/rendered/serviceaccount.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ metadata:
1010
app.kubernetes.io/managed-by: Helm
1111
app.kubernetes.io/name: nr-k8s-otel-collector
1212
app.kubernetes.io/version: 1.2.0
13-
helm.sh/chart: nr-k8s-otel-collector-0.10.7
13+
helm.sh/chart: nr-k8s-otel-collector-0.10.8
1414
annotations:

0 commit comments

Comments
 (0)