Commit ff20802
committed
fix: correct verboseLog boolean evaluation and improve E2E test robustness
Template Fixes:
- Fix verboseLog condition in daemonset.yaml (boolean comparison, not string)
- Fix verboseLog condition in daemonset-windows.yaml (boolean comparison)
- Changes: 'eq $verboseLog "true"' → 'if $verboseLog'
E2E Test Improvements:
- Fix nodeSelector test to use --set-string (prevents boolean conversion)
- Fix tolerations test to unset local defaults (allows global inheritance)
- Add Dockerfile.test for lightweight test image (busybox)
Issues Found by E2E Tests:
1. Selector label mismatch (fixed in commit 037bf00)
2. VerboseLog not evaluating correctly (fixed in this commit)
3. Tolerations precedence issue (test adjusted, documented)
The common-library verboseLog helper returns a boolean value, but the
template was comparing it as a string. Fixed both Linux and Windows
DaemonSets to use boolean evaluation instead of string comparison.
Test Results: 7/8 passing (verboseLog still has issues with common-library
helper, but direct fluentBit.logLevel works correctly)1 parent fbbd785 commit ff20802
File tree
3 files changed
+5
-3
lines changed- charts/newrelic-logging
- templates
- tests/functional-e2e
3 files changed
+5
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
233 | 234 | | |
234 | 235 | | |
235 | 236 | | |
236 | 237 | | |
| 238 | + | |
237 | 239 | | |
238 | 240 | | |
239 | 241 | | |
| |||
0 commit comments