chore(style): follow style guide (#1741)

Author: paologallinaharbur

agent-control/src/agent_control/run.rs

@@ -9,7 +9,6 @@ use crate::agent_control::http_server::runner::Runner;
 use crate::agent_type::embedded_registry::EmbeddedRegistry;
 use crate::agent_type::variable::constraints::VariableConstraints;
 use crate::event::broadcaster::unbounded::UnboundedBroadcast;
-
 use crate::event::{AgentControlEvent, ApplicationEvent, SubAgentEvent, channel::EventConsumer};
 use crate::http::config::ProxyConfig;
 use crate::opamp::auth::token_retriever::TokenRetrieverImpl;

agent-control/src/agent_control/run/k8s.rs

@@ -143,7 +143,7 @@ impl AgentControlRunner {
         let template_renderer = TemplateRenderer::default()
             .with_agent_control_variables(agent_control_variables.clone().into_iter());
 
-        let mut secrets_providers = SecretsProviders::new()
+        let mut secrets_providers = SecretsProviders::default()
             .with_env()
             .with_k8s_secret(k8s_client.clone());
         if let Some(config) = &agent_control_config.secrets_providers {

agent-control/src/agent_control/run/on_host.rs

@@ -137,7 +137,7 @@ impl AgentControlRunner {
         let template_renderer = TemplateRenderer::default()
             .with_agent_control_variables(agent_control_variables.clone().into_iter());
 
-        let mut secrets_providers = SecretsProviders::new().with_env();
+        let mut secrets_providers = SecretsProviders::default().with_env();
         if let Some(config) = &agent_control_config.secrets_providers {
             secrets_providers = secrets_providers.with_config(config.clone()).map_err(|e| {
                 AgentError::ConfigResolve(AgentControlConfigError::Load(format!(

agent-control/src/agent_type/variable/secret_variables.rs

@@ -217,7 +217,7 @@ eof"#;
         let secrets = SecretVariables {
             variables: HashMap::new(),
         };
-        let result = secrets.load_secrets(&SecretsProviders::new()).unwrap();
+        let result = secrets.load_secrets(&SecretsProviders::default()).unwrap();
         assert!(result.is_empty());
     }
 }

agent-control/src/context.rs

@@ -7,10 +7,6 @@ impl<T> Context<T>
 where
     T: Default,
 {
-    pub fn new() -> Self {
-        Self::default()
-    }
-
     /// Sets the cancellation signal. All threads that are waiting for this signal (i.e. were passed this [`Context`] are notified so they unblock and finish execution, cancelling the processes.
     pub fn cancel_all(&self, val: T) -> Result<(), PoisonError<MutexGuard<'_, T>>> /* this is the error type returned by a failed `lock()` */
     {
@@ -48,7 +44,7 @@ mod tests {
     fn test_context_can_be_cancelled_while_waiting() {
         let after_cancel = Arc::new(Mutex::new(()));
         let after_cancel_clone = after_cancel.clone();
-        let ctx: Context<bool> = Context::new();
+        let ctx: Context<bool> = Context::default();
         let ctx_clone = ctx.clone();
         let guard = after_cancel.lock().unwrap();
         thread::spawn(move || {

agent-control/src/health/with_start_time.rs

@@ -94,10 +94,6 @@ impl HealthWithStartTime {
         }
     }
 
-    pub fn is_same_without_times(&self, other: &Self) -> bool {
-        self.health == other.health
-    }
-
     pub fn as_health(&self) -> &Health {
         &self.health
     }

agent-control/src/secrets_provider.rs

@@ -90,19 +90,20 @@ impl SecretsProvider for SecretsProviderType {
 /// Collection of [SecretsProviderType]s.
 pub type SecretsProviders = Registry<SecretsProviderType>;
 
-#[derive(Default)]
 pub struct Registry<S: SecretsProvider>(HashMap<Namespace, S>);
 
 impl<S: SecretsProvider> Registry<S> {
-    pub fn new() -> Self {
-        Registry(HashMap::new())
-    }
-
     pub fn is_empty(&self) -> bool {
         self.0.is_empty()
     }
 }
 
+impl Default for Registry<SecretsProviderType> {
+    fn default() -> Self {
+        Self(HashMap::new())
+    }
+}
+
 impl Registry<SecretsProviderType> {
     pub fn with_env(mut self) -> Self {
         self.0.insert(

agent-control/src/sub_agent.rs

@@ -996,7 +996,7 @@ deployment:
             Arc::new(TestAgent::agent_type_definition().into()),
             TemplateRenderer::default(),
             VariableConstraints::default(),
-            SecretsProviders::new(),
+            SecretsProviders::default(),
             PathBuf::default().as_path(),
         ));
 
@@ -1082,7 +1082,7 @@ deployment:
             Arc::new(EmbeddedRegistry::from(TestAgent::agent_type_definition())),
             TemplateRenderer::default(),
             VariableConstraints::default(),
-            SecretsProviders::new(),
+            SecretsProviders::default(),
             PathBuf::default().as_path(),
         ));
 
@@ -1531,7 +1531,7 @@ deployment:
             Arc::new(TestAgent::agent_type_definition_with_required_var().into()),
             TemplateRenderer::default(),
             VariableConstraints::default(),
-            SecretsProviders::new(),
+            SecretsProviders::default(),
             PathBuf::default().as_path(),
         ));
 

agent-control/src/sub_agent/effective_agents_assembler.rs

@@ -279,7 +279,7 @@ pub(crate) mod tests {
                 registry: Arc::new(registry),
                 renderer: TemplateRenderer::default(),
                 variable_constraints: VariableConstraints::default(),
-                secrets_providers: SecretsProviders::new(),
+                secrets_providers: SecretsProviders::default(),
                 auto_generated_dir: PathBuf::default(),
             }
         }

agent-control/src/sub_agent/on_host/builder.rs

@@ -170,7 +170,7 @@ impl SupervisorBuilder for SupervisortBuilderOnHost {
         let executable_supervisors = NotStartedSupervisorOnHost::new(
             effective_agent.get_agent_identity().clone(),
             executables,
-            Context::new(),
+            Context::default(),
             on_host.health,
             on_host.version,
         )