test(k8s): Increase GC period (#1073)

Author: gsanchezgavier

agent-control/tests/common/agent_control.rs

@@ -11,6 +11,8 @@ use newrelic_agent_control::values::file::YAMLConfigRepositoryFile;
 use std::sync::Arc;
 use std::time::Duration;
 
+pub const K8S_GC_INTERVAL: Duration = Duration::from_secs(5);
+
 /// Starts the agent-control in a separate thread. The agent-control will be stopped when the `StartedAgentControl` is dropped.
 /// Take into account that some of the logic from main is not present here.
 pub fn start_agent_control_with_custom_config(base_paths: BasePaths) -> StartedAgentControl {
@@ -30,8 +32,8 @@ pub fn start_agent_control_with_custom_config(base_paths: BasePaths) -> StartedA
 
         let agent_control_config = config_storer.load().unwrap();
 
-        let opamp_poll_interval = Duration::from_secs(2);
-        let garbage_collector_interval = Duration::from_secs(1);
+        let opamp_poll_interval = Duration::from_secs(10);
+        let garbage_collector_interval = K8S_GC_INTERVAL;
         // TODO - Temporal solution until https://new-relic.atlassian.net/browse/NR-343594 is done.
         // There is a current issue with the diff computation the GC does in order to collect agents. If a new agent is added and removed
         // before the GC process it, the resources will never be collected.

agent-control/tests/k8s/scenarios/cr_based_agents.rs

@@ -1,3 +1,4 @@
+use crate::common::agent_control::K8S_GC_INTERVAL;
 use crate::k8s::tools::agent_control::BAR_CR_AGENT_TYPE_PATH;
 use crate::k8s::tools::k8s_api::check_config_map_exist;
 use crate::k8s::tools::test_crd::{create_crd, delete_crd, Foo};
@@ -20,6 +21,7 @@ use kube::{Api, CustomResource, CustomResourceExt};
 use newrelic_agent_control::agent_control::config::AgentID;
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
+use std::ops::Add;
 use std::time::Duration;
 use tempfile::tempdir;
 
@@ -77,8 +79,12 @@ agents:
         Ok(())
     });
 
-    // Asserts the agent resources are garbage collected
+    // This function is used to wait for the k8s garbage collector to run.
+    // It is used in tests to ensure that the garbage collector has run before checking the state of the system.
+    // This is a HACK until we address the GC refactor.
+    std::thread::sleep(K8S_GC_INTERVAL.add(Duration::from_millis(100)));
 
+    // Asserts the agent resources are garbage collected
     server.set_config_response(
         instance_id.clone(),
         ConfigResponse::from(