refactor: skip redundant dynamic object change detection (#946)

* refactor: remove redundant `has_dynamic_object_changed` calls

* test: remove mock expectation to call has_dynamic_object_changed

Author: DavSanchez

agent-control/src/sub_agent/health/k8s/helm_release.rs

@@ -154,23 +154,6 @@ impl HealthChecker for K8sHealthFluxHelmRelease {
             HealthCheckerError::Generic("HelmRelease data is not an object".to_string())
         })?;
 
-        // Check if the HelmRelease is properly updated: it should reflect the agent's configuration
-        if self
-            .k8s_client
-            .has_dynamic_object_changed(&self.k8s_object)?
-        {
-            return Ok(HealthWithStartTime::from_unhealthy(
-                Unhealthy::new(
-                    String::default(),
-                    format!(
-                        "HelmRelease '{}' does not match the latest agent configuration",
-                        &self.name,
-                    ),
-                ),
-                self.start_time,
-            ));
-        }
-
         let status = self.get_status(helm_release_data)?;
         let conditions = self.get_status_conditions(&status)?;
 
@@ -207,15 +190,6 @@ pub mod tests {
             fn(&mut MockSyncK8sClient),
         );
         let test_cases : Vec<TestCase> = vec![
-            (
-                "Helm release unhealthy when the helm-release object should change",
-                Ok(Unhealthy::new(String::default(),"HelmRelease 'example-release' does not match the latest agent configuration".to_string()).into()),
-                |mock: &mut MockSyncK8sClient| {
-                    mock.expect_get_dynamic_object()
-                        .returning(|_,_| Ok(Some(Arc::new(dynamic_object()))));
-                    mock.expect_has_dynamic_object_changed().times(1).returning(|_| Ok(true));
-                },
-            ),
             (
                 "Helm release healthy when ready and status true",
                 Ok(Healthy::default().into()),
@@ -337,7 +311,5 @@ pub mod tests {
                     }),
                 })))
             });
-        mock.expect_has_dynamic_object_changed()
-            .returning(|_| Ok(false));
     }
 }

agent-control/src/sub_agent/health/k8s/instrumentation.rs

@@ -149,23 +149,6 @@ impl HealthChecker for K8sHealthNRInstrumentation {
             HealthCheckerError::Generic("instrumentation CR data is not an object".to_string())
         })?;
 
-        // Check if the instrumentation is properly updated: it should reflect the agent's configuration
-        if self
-            .k8s_client
-            .has_dynamic_object_changed(&self.k8s_object)?
-        {
-            return Ok(HealthWithStartTime::from_unhealthy(
-                Unhealthy::new(
-                    String::default(),
-                    format!(
-                        "instrumentation CR '{}' does not match the latest agent configuration",
-                        &self.name,
-                    ),
-                ),
-                self.start_time,
-            ));
-        }
-
         let status = instrumentation_data.get("status").cloned().ok_or_else(|| {
             HealthCheckerError::Generic("instrumentation status could not be retrieved".to_string())
         })?;