fix(config_migrate): logs were disabled (#1792)

* fix(config_migrate): logs were disabled

We use a filtering mechanism in which we disabled all logs not coming from `newrelic_agent_control` crate, which excluded `newrelic_config_migrate`

the filters used make it tricky to configure logging properly for config_migrate. For example, debug log level cannot be activated, and previously the logs would be emitted depending on if the 'callsite' is inside the AC crate or not.

the error handling of `config_migrate` needs to be improved in any case.

* test: new default case

Author: DavSanchez

agent-control/src/bin/main_config_migrate.rs

@@ -15,7 +15,7 @@ use tracing::{debug, info, warn};
 fn main() -> Result<(), Box<dyn Error>> {
     let cli = Cli::load();
     let tracing_config = TracingConfig::from_logging_path(cli.log_dir());
-    let _tracer = try_init_tracing(tracing_config);
+    let _tracer = try_init_tracing(tracing_config)?;
 
     info!("Starting config conversion tool...");
 

agent-control/src/instrumentation/config/logs/config.rs

@@ -11,7 +11,11 @@ use tracing_subscriber::fmt::format::FmtSpan;
 use tracing_subscriber::layer::Filter;
 use tracing_subscriber::{EnvFilter, Registry};
 
-const LOGGING_ENABLED_CRATES: &[&str] = &["newrelic_agent_control", "opamp_client"];
+const LOGGING_ENABLED_CRATES: &[&str] = &[
+    "newrelic_agent_control",
+    "opamp_client",
+    "newrelic_config_migrate",
+];
 
 const SPAN_ATTRIBUTES_MAX_LEVEL: &Level = &Level::INFO;
 
@@ -202,7 +206,7 @@ mod tests {
             TestCase {
                 name: "everything default",
                 config: Default::default(),
-                expected: "newrelic_agent_control=info,opamp_client=info,off",
+                expected: "newrelic_config_migrate=info,newrelic_agent_control=info,opamp_client=info,off",
             },
             TestCase {
                 name: "insecure fine grained overrides any logging",
@@ -219,7 +223,7 @@ mod tests {
                     insecure_fine_grained_level: Some("".into()),
                     ..Default::default()
                 },
-                expected: "newrelic_agent_control=info,opamp_client=info,off", // default
+                expected: "newrelic_config_migrate=info,newrelic_agent_control=info,opamp_client=info,off", // default
             },
             TestCase {
                 name: "several specific targets in insecure_fine_grained_level",