Skip to content

Commit 857faac

Browse files
fix: tree
1 parent c254cce commit 857faac

File tree

4 files changed

+50
-34
lines changed

4 files changed

+50
-34
lines changed

agent-control/agent-type-registry/newrelic/com.newrelic.infrastructure-0.1.0.yaml

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,18 @@ variables:
5151
description: "Username for HTTP Basic authentication"
5252
type: string
5353
required: false
54-
default: null
54+
default: ""
5555
password:
5656
description: "Password for HTTP Basic authentication"
5757
type: string
5858
required: false
59-
default: null
59+
default: ""
6060
bearer:
61-
description: "Bearer token for authentication"
62-
type: string
63-
required: false
64-
default: null
61+
token:
62+
description: "Bearer token for authentication"
63+
type: string
64+
required: false
65+
default: ""
6566
version:
6667
description: "Agent version"
6768
type: string
@@ -120,17 +121,18 @@ variables:
120121
description: "Username for HTTP Basic authentication"
121122
type: string
122123
required: false
123-
default: null
124+
default: ""
124125
password:
125126
description: "Password for HTTP Basic authentication"
126127
type: string
127128
required: false
128-
default: null
129+
default: ""
129130
bearer:
130-
description: "Bearer token for authentication"
131-
type: string
132-
required: false
133-
default: null
131+
token:
132+
description: "Bearer token for authentication"
133+
type: string
134+
required: false
135+
default: ""
134136
version:
135137
description: "Agent version"
136138
type: string
@@ -224,7 +226,8 @@ deployment:
224226
basic:
225227
username: ${nr-var:oci.auth.basic.username}
226228
password: ${nr-var:oci.auth.basic.password}
227-
bearer: ${nr-var:oci.auth.bearer}
229+
bearer:
230+
token: ${nr-var:oci.auth.bearer.token}
228231
version:
229232
path: ${nr-sub:packages.infra-agent.dir}\\newrelic-infra.exe
230233
args:
@@ -299,7 +302,8 @@ deployment:
299302
basic:
300303
username: ${nr-var:oci.auth.basic.username}
301304
password: ${nr-var:oci.auth.basic.password}
302-
bearer: ${nr-var:oci.auth.bearer}
305+
bearer:
306+
token: ${nr-var:oci.auth.bearer.token}
303307
version:
304308
path: ${nr-sub:packages.infra-agent.dir}/newrelic-infra
305309
args:

agent-control/agent-type-registry/newrelic/com.newrelic.opentelemetry.collector-0.1.0.yaml

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -55,17 +55,18 @@ variables:
5555
description: "Username for HTTP Basic authentication"
5656
type: string
5757
required: false
58-
default: null
58+
default: ""
5959
password:
6060
description: "Password for HTTP Basic authentication"
6161
type: string
6262
required: false
63-
default: null
63+
default: ""
6464
bearer:
65-
description: "Bearer token for authentication"
66-
type: string
67-
required: false
68-
default: null
65+
token:
66+
description: "Bearer token for authentication"
67+
type: string
68+
required: false
69+
default: ""
6970
version:
7071
description: "Agent version"
7172
type: string
@@ -118,17 +119,18 @@ variables:
118119
description: "Username for HTTP Basic authentication"
119120
type: string
120121
required: false
121-
default: null
122+
default: ""
122123
password:
123124
description: "Password for HTTP Basic authentication"
124125
type: string
125126
required: false
126-
default: null
127+
default: ""
127128
bearer:
128-
description: "Bearer token for authentication"
129-
type: string
130-
required: false
131-
default: null
129+
token:
130+
description: "Bearer token for authentication"
131+
type: string
132+
required: false
133+
default: ""
132134
version:
133135
description: "Agent version"
134136
type: string
@@ -195,7 +197,8 @@ deployment:
195197
basic:
196198
username: ${nr-var:oci.auth.basic.username}
197199
password: ${nr-var:oci.auth.basic.password}
198-
bearer: ${nr-var:oci.auth.bearer}
200+
bearer:
201+
token: ${nr-var:oci.auth.bearer.token}
199202
version:
200203
path: ${nr-sub:packages.nrdot.dir}\\nrdot-collector.exe
201204
args:
@@ -233,7 +236,8 @@ deployment:
233236
basic:
234237
username: ${nr-var:oci.auth.basic.username}
235238
password: ${nr-var:oci.auth.basic.password}
236-
bearer: ${nr-var:oci.auth.bearer}
239+
bearer:
240+
token: ${nr-var:oci.auth.bearer.token}
237241
health:
238242
interval: 30s
239243
initial_delay: 90s

agent-control/src/agent_type/runtime_config/on_host.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@ executables:
784784
Variable::new_final_string_variable(creds.password.to_string()),
785785
);
786786
vars.insert(
787-
"nr-var:oci.auth.bearer".to_string(),
787+
"nr-var:oci.auth.bearer.token".to_string(),
788788
Variable::new_final_string_variable(creds.bearer.to_string()),
789789
);
790790

@@ -864,6 +864,7 @@ packages:
864864
basic:
865865
username: ${nr-var:oci.auth.basic.username}
866866
password: ${nr-var:oci.auth.basic.password}
867-
bearer: ${nr-var:oci.auth.bearer}
867+
bearer:
868+
token: ${nr-var:oci.auth.bearer.token}
868869
"#;
869870
}

agent-control/src/agent_type/runtime_config/on_host/package.rs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ pub struct Oci {
4242
#[derive(Debug, Deserialize, Default, Clone, PartialEq)]
4343
pub struct Auth {
4444
pub basic: BasicAuth,
45-
pub bearer: TemplateableValue<String>,
45+
pub bearer: BearerAuth,
4646
}
4747

4848
#[derive(Debug, Deserialize, Default, Clone, PartialEq)]
@@ -51,6 +51,11 @@ pub struct BasicAuth {
5151
pub password: TemplateableValue<String>,
5252
}
5353

54+
#[derive(Debug, Deserialize, Default, Clone, PartialEq)]
55+
pub struct BearerAuth {
56+
pub token: TemplateableValue<String>,
57+
}
58+
5459
impl Templateable for Package {
5560
type Output = rendered::Package;
5661
fn template_with(self, variables: &Variables) -> Result<Self::Output, AgentTypeError> {
@@ -120,7 +125,7 @@ impl Templateable for Auth {
120125
return Ok(RegistryAuth::Basic(username, password));
121126
}
122127

123-
let token = self.bearer.template_with(variables)?;
128+
let token = self.bearer.token.template_with(variables)?;
124129
if !token.is_empty() {
125130
return Ok(RegistryAuth::Bearer(token));
126131
}
@@ -229,7 +234,7 @@ mod tests {
229234
username: TemplateableValue::from_template("${nr-var:username}".to_string()),
230235
password: TemplateableValue::from_template("${nr-var:password}".to_string()),
231236
},
232-
bearer: TemplateableValue::default(),
237+
bearer: BearerAuth::default(),
233238
},
234239
};
235240

@@ -255,7 +260,9 @@ mod tests {
255260
public_key_url: None,
256261
auth: Auth {
257262
basic: BasicAuth::default(),
258-
bearer: TemplateableValue::from_template("${nr-var:token}".to_string()),
263+
bearer: BearerAuth {
264+
token: TemplateableValue::from_template("${nr-var:token}".to_string()),
265+
},
259266
},
260267
};
261268

0 commit comments

Comments
 (0)