feat: add repository url flag to cli (#1326)

Author: danielorihuela

agent-control/src/cli/install_agent_control.rs

@@ -74,6 +74,10 @@ pub struct AgentControlInstallData {
     /// Initial delay for installation check
     #[arg(long, default_value = INSTALLATION_CHECK_DEFAULT_INITIAL_DELAY, value_parser = parse_duration_arg)]
     pub installation_check_initial_delay: Duration,
+
+    /// Repository URl from where the chart will be downloaded
+    #[arg(long, default_value = REPOSITORY_URL)]
+    pub repository_url: String,
 }
 
 // helper needed because the arguments from the duration_str's parse function and the one expected by the clap
@@ -146,13 +150,18 @@ impl From<AgentControlInstallData> for Vec<DynamicObject> {
         let annotations = annotations.get();
 
         vec![
-            helm_repository(labels.clone(), annotations.clone()),
+            helm_repository(
+                value.repository_url.clone(),
+                labels.clone(),
+                annotations.clone(),
+            ),
             helm_release(&value, labels, annotations),
         ]
     }
 }
 
 fn helm_repository(
+    repository_url: String,
     labels: BTreeMap<String, String>,
     annotations: BTreeMap<String, String>,
 ) -> DynamicObject {
@@ -166,7 +175,7 @@ fn helm_repository(
         },
         data: serde_json::json!({
             "spec": {
-                "url": REPOSITORY_URL,
+                "url": repository_url,
                 "interval": FIVE_MINUTES,
             }
         }),
@@ -296,6 +305,7 @@ mod tests {
             skip_installation_check: false,
             installation_check_initial_delay: Duration::from_secs(10),
             installation_check_timeout: Duration::from_secs(300),
+            repository_url: REPOSITORY_URL.to_string(),
         }
     }
 

agent-control/tests/k8s/agent_control_cli/dynamic_objects.rs

@@ -110,3 +110,29 @@ fn k8s_cli_install_agent_control_creates_resources() {
         )
     );
 }
+
+#[test]
+#[ignore = "needs k8s cluster"]
+fn k8s_cli_install_agent_control_creates_resources_with_specific_repository_url() {
+    let runtime = crate::common::runtime::tokio_runtime();
+
+    let mut k8s_env = runtime.block_on(K8sEnv::new());
+    let namespace = runtime.block_on(k8s_env.test_namespace());
+
+    let repository_url = "https://cli-charts.newrelic.com";
+    let mut cmd = Command::cargo_bin("newrelic-agent-control-cli").unwrap();
+    cmd.arg("install-agent-control");
+    cmd.arg("--release-name").arg(RELEASE_NAME);
+    cmd.arg("--chart-version").arg("1.0.0");
+    cmd.arg("--namespace").arg(namespace.clone());
+    cmd.arg("--skip-installation-check"); // Skipping checks because we are merely checking that the resources are created.
+    cmd.arg("--repository-url").arg(repository_url);
+    cmd.assert().success();
+
+    let k8s_client = SyncK8sClient::try_new(runtime.clone(), namespace.clone()).unwrap();
+    let repository = k8s_client
+        .get_dynamic_object(&helmrepository_type_meta(), REPOSITORY_NAME)
+        .unwrap()
+        .unwrap();
+    assert_eq!(repository.data["spec"]["url"], repository_url);
+}