feat(windows): release pipeline

paologallinaharbur · paologallinaharbur · commit af0474b6ecaf · 2025-11-24T16:56:59.000+01:00
diff --git a/.github/workflows/component_packages.yml b/.github/workflows/component_packages.yml
@@ -12,8 +12,8 @@ on:
         type: boolean
         required: false
         default: false
-      skip_upload_artifact:
-        description: 'skip uploading the artifact'
+      skip_upload_pipeline:
+        description: 'skip uploading the artifact to the github pipeline'
         type: boolean
         required: false
         default: false
@@ -83,7 +83,7 @@ jobs:
         run: |
           cargo install --locked cargo-xwin --force
 
-      - name: Set tag and skip_upload=false for pre-release
+      - name: If pre-release set and verify tag matches Cargo.toml version
         if: ${{ inputs.pre-release}}
         run: |
           NEWRELIC_AGENT_CONTROL_VERSION=$(sed -n 's/^version = "\(.*\)"/\1/p' agent-control/Cargo.toml)
@@ -92,11 +92,11 @@ jobs:
             exit 1
           fi
 
-      - name: Set tag and skip_upload=true for testing
+      - name: If not pre-release, set tag and SKIP_UPLOAD_RELEASE=true
         if: ${{ ! inputs.pre-release }}
         run: |
           git tag ${{ inputs.tag_name }}
-          echo SKIP_UPLOAD="--skip=publish" >> $GITHUB_ENV
+          echo SKIP_UPLOAD_RELEASE="--skip=publish" >> $GITHUB_ENV
 
       - name: Skip packages sign
         if: ${{ inputs.skip_sign }}
@@ -106,7 +106,7 @@ jobs:
       - name: Release packages with GoReleaser
         uses: goreleaser/goreleaser-action@e435ccd777264be153ace6237001ef4d979d3a7a # v6
         with:
-          args: release ${{ env.SKIP_UPLOAD }} ${{ env.SKIP_SIGN }} --clean --verbose --timeout 2h
+          args: release ${{ env.SKIP_UPLOAD_RELEASE }} ${{ env.SKIP_SIGN }} --clean --verbose --timeout 2h
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GPG_PASSPHRASE: ${{ secrets.OHAI_GPG_PASSPHRASE }}
@@ -116,7 +116,7 @@ jobs:
           GORELEASER_CURRENT_TAG: ${{ inputs.tag_name }}
 
       - name: Upload assets to pipeline
-        if: ${{ !inputs.skip_upload_artifact }}
+        if: ${{ !inputs.skip_upload_pipeline }}
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
         with:
           retention-days: 1
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -64,7 +64,32 @@ jobs:
           app_name: "newrelic-agent-control"
           repo_name: ${{ github.repository }}
           schema: "custom-local"
-          schema_path: "./build/upload-schema-linux-deb-nightly.yml"
+          schema_path: "/srv/build/upload-schema-linux-deb-nightly.yml"
+          aws_access_key_id: ${{ secrets.OHAI_AWS_ACCESS_KEY_ID_TESTING }}
+          aws_secret_access_key: ${{ secrets.OHAI_AWS_SECRET_ACCESS_KEY_TESTING }}
+          aws_s3_bucket_name: "nr-downloads-ohai-testing"
+          aws_s3_lock_bucket_name: "onhost-ci-lock-testing"
+          access_point_host: "testing"
+          run_id: ${{ github.run_id }}
+          aws_region: "us-east-1"
+          aws_role_session_name: ${{ secrets.OHAI_AWS_ROLE_SESSION_NAME_TESTING }}
+          aws_role_arn: ${{ secrets.OHAI_AWS_ROLE_ARN_TESTING }}
+          # used for signing package stuff
+          gpg_passphrase: ${{ secrets.OHAI_GPG_PASSPHRASE }}
+          gpg_private_key_base64: ${{ secrets.OHAI_GPG_PRIVATE_KEY_BASE64 }} # base64 encoded
+          disable_lock: false
+          dest_prefix: "preview/"
+          local_packages_path: "/srv/dist/"
+          apt_skip_mirror: true
+
+      - name: Publish windows artifacts
+        uses: newrelic/infrastructure-publish-action@v1
+        with:
+          tag: 0.100.${{ github.run_id }}
+          app_name: "newrelic-agent-control"
+          repo_name: ${{ github.repository }}
+          schema: "custom-local"
+          schema_path: "/srv/build/upload-schema-windows-zip.yml"
           aws_access_key_id: ${{ secrets.OHAI_AWS_ACCESS_KEY_ID_TESTING }}
           aws_secret_access_key: ${{ secrets.OHAI_AWS_SECRET_ACCESS_KEY_TESTING }}
           aws_s3_bucket_name: "nr-downloads-ohai-testing"
diff --git a/.github/workflows/on_demand_release.yml b/.github/workflows/on_demand_release.yml
@@ -25,6 +25,31 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Publish windows artifacts
+        uses: newrelic/infrastructure-publish-action@v1
+        with:
+          tag: ${{ github.event.inputs.tag }}
+          app_name: "newrelic-agent-control"
+          repo_name: ${{ github.repository }}
+          schema: "custom-local"
+          schema_path: "/srv/build/upload-schema-windows-zip.yml"
+          aws_access_key_id: ${{ secrets.TMP_OHAI_AWS_ACCESS_KEY_ID_PRODUCTION }}
+          aws_secret_access_key: ${{ secrets.TMP_OHAI_AWS_SECRET_ACCESS_KEY_PRODUCTION }}
+          aws_s3_bucket_name: "nr-downloads-main"
+          aws_s3_lock_bucket_name: "onhost-ci-lock"
+          access_point_host: "production"
+          run_id: ${{ github.run_id }}
+          aws_region: "us-east-1"
+          aws_role_session_name: ${{ secrets.TMP_OHAI_AWS_ROLE_SESSION_NAME_PRODUCTION }}
+          aws_role_arn: ${{ secrets.TMP_OHAI_AWS_ROLE_ARN_PRODUCTION }}
+          # used for signing package stuff
+          gpg_passphrase: ${{ secrets.OHAI_GPG_PASSPHRASE }}
+          gpg_private_key_base64: ${{ secrets.OHAI_GPG_PRIVATE_KEY_BASE64 }} # base64 encoded
+          disable_lock: false
+          dest_prefix: "preview/"
+          local_packages_path: "/srv/dist/"
+          apt_skip_mirror: false
+
       - name: Publish deb to S3 action
         uses: newrelic/infrastructure-publish-action@v1
         with:
diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml
@@ -51,6 +51,31 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Publish windows artifacts
+        uses: newrelic/infrastructure-publish-action@v1
+        with:
+          tag: ${{ github.event.release.tag_name }}
+          app_name: "newrelic-agent-control"
+          repo_name: ${{ github.repository }}
+          schema: "custom-local"
+          schema_path: "/srv/build/upload-schema-windows-zip.yml"
+          aws_access_key_id: ${{ secrets.TMP_OHAI_AWS_ACCESS_KEY_ID_STAGING }}
+          aws_secret_access_key: ${{ secrets.TMP_OHAI_AWS_SECRET_ACCESS_KEY_STAGING }}
+          aws_s3_bucket_name: "nr-downloads-ohai-staging"
+          aws_s3_lock_bucket_name: "onhost-ci-lock-staging"
+          access_point_host: "staging"
+          run_id: ${{ github.run_id }}
+          aws_region: "us-east-1"
+          aws_role_session_name: ${{ secrets.TMP_OHAI_AWS_ROLE_SESSION_NAME_STAGING }}
+          aws_role_arn: ${{ secrets.TMP_OHAI_AWS_ROLE_ARN_STAGING }}
+          # used for signing package stuff
+          gpg_passphrase: ${{ secrets.OHAI_GPG_PASSPHRASE }}
+          gpg_private_key_base64: ${{ secrets.OHAI_GPG_PRIVATE_KEY_BASE64 }} # base64 encoded
+          disable_lock: false
+          dest_prefix: "preview/"
+          local_packages_path: "/srv/dist/"
+          apt_skip_mirror: false
+
       - name: Publish deb to S3 action
         uses: newrelic/infrastructure-publish-action@v1
         with:
diff --git a/.github/workflows/push_pr_package.yml b/.github/workflows/push_pr_package.yml
@@ -21,7 +21,7 @@ jobs:
     uses: ./.github/workflows/component_packages.yml
     with:
       pre-release: false
-      skip_upload_artifact: true
+      skip_upload_pipeline: true
       skip_sign: true
       tag_name: 0.100.0
 
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -73,6 +73,31 @@ jobs:
           dest_prefix: "preview/"
           local_packages_path: "/srv/dist/"
           apt_skip_mirror: false
+
+      - name: Publish windows artifacts
+        uses: newrelic/infrastructure-publish-action@v1
+        with:
+          tag: ${{ github.event.release.tag_name }}
+          app_name: "newrelic-agent-control"
+          repo_name: ${{ github.repository }}
+          schema: "custom-local"
+          schema_path: "/srv/build/upload-schema-windows-zip.yml"
+          aws_access_key_id: ${{ secrets.TMP_OHAI_AWS_ACCESS_KEY_ID_PRODUCTION }}
+          aws_secret_access_key: ${{ secrets.TMP_OHAI_AWS_SECRET_ACCESS_KEY_PRODUCTION }}
+          aws_s3_bucket_name: "nr-downloads-main"
+          aws_s3_lock_bucket_name: "onhost-ci-lock"
+          access_point_host: "production"
+          run_id: ${{ github.run_id }}
+          aws_region: "us-east-1"
+          aws_role_session_name: ${{ secrets.TMP_OHAI_AWS_ROLE_SESSION_NAME_PRODUCTION }}
+          aws_role_arn: ${{ secrets.TMP_OHAI_AWS_ROLE_ARN_PRODUCTION }}
+          # used for signing package stuff
+          gpg_passphrase: ${{ secrets.OHAI_GPG_PASSPHRASE }}
+          gpg_private_key_base64: ${{ secrets.OHAI_GPG_PRIVATE_KEY_BASE64 }} # base64 encoded
+          disable_lock: false
+          dest_prefix: "preview/"
+          local_packages_path: "/srv/dist/"
+          apt_skip_mirror: false
   
   push-container-tags:
     runs-on: ubuntu-latest
diff --git a/.goreleaser.yml b/.goreleaser.yml
@@ -85,8 +85,18 @@ builds:
           output: true
 
 archives:
-  - formats: tar.gz
+  - id: linux
+    formats: tar.gz
     name_template: "{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}"
+    builds:
+      - newrelic-agent-control-linux
+      - newrelic-agent-control-cli-linux
+  - id: windows
+    formats: zip
+    name_template: "{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}"
+    builds:
+      - newrelic-agent-control-windows
+      - newrelic-agent-control-cli-windows
 
 nfpms: # deb and rpm are only built for linux targets
   - package_name: newrelic-agent-control
@@ -218,7 +228,7 @@ signs:
 
     # Path to the checksum command.
     cmd: ./build/scripts/generate_checksum.sh
-    args: ["-f", "{{ .Env.artifact }}"]
+    args: [ "-f", "{{ .Env.artifact }}" ]
     artifacts: all
   - id: signing
 
diff --git a/agent-control/src/agent_control/defaults.rs b/agent-control/src/agent_control/defaults.rs
@@ -16,7 +16,7 @@ pub const AGENT_CONTROL_VERSION: &str = env!("CARGO_PKG_VERSION");
 
 // Keys identifying attributes
 pub const OPAMP_SUBAGENT_CHART_VERSION_ATTRIBUTE_KEY: &str = "chart.version";
-pub const OPAMP_AC_CHART_VERSION_ATTRIBUTE_KEY: &str = "chart.version"; // TODO `ac.chart.version`?
+pub const OPAMP_AC_CHART_VERSION_ATTRIBUTE_KEY: &str = "chart.version";
 pub const OPAMP_CD_CHART_VERSION_ATTRIBUTE_KEY: &str = "cd.chart.version";
 pub const OPAMP_SERVICE_NAME: &str = "service.name";
 pub const OPAMP_SERVICE_VERSION: &str = "service.version";
diff --git a/build/upload-schema-windows-zip.yml b/build/upload-schema-windows-zip.yml
@@ -0,0 +1,18 @@
+---
+- src: "newrelic-agent-control_{version}_windows_{arch}.zip"
+  uploads:
+    - type: file
+      dest: "{dest_prefix}binaries/windows/{arch}/{src}"
+  arch:
+    - amd64
+
+  #########################
+  # UPLOAD CHECKSUMS #
+#########################
+
+- src: "newrelic-agent-control_{version}_windows_{arch}.zip.sum"
+  uploads:
+    - type: file
+      dest: "{dest_prefix}binaries/windows/{arch}/{src}"
+  arch:
+    - amd64
