Skip to content

Commit b4dddc8

Browse files
fix(comment): the label is not useless (#1774)
1 parent aadbcb2 commit b4dddc8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

agent-control/src/cli/k8s/install/agent_control.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ impl DynamicObjectListBuilder for InstallAgentControl {
5656
labels.clone(),
5757
annotations.clone(),
5858
);
59-
// This is not strictly necessary, but it helps to ensure that the labels are consistent
59+
// This is needed whenever the version is managed remotely (otherwise we would lose such info)
60+
// Moreover, we add it also when it is local to be consistent.
6061
let mut helm_release_labels = labels;
6162
helm_release_labels.insert(AGENT_CONTROL_VERSION_SET_FROM.to_string(), source);
6263

agent-control/src/cli/k8s/install/flux.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ impl DynamicObjectListBuilder for InstallFlux {
4747
BTreeMap::default(),
4848
);
4949

50-
// This is not strictly necessary, but it helps to ensure that the labels are consistent
50+
// This is needed whenever the version is managed remotely (otherwise we would lose such info)
51+
// Moreover, we add it also when it is local to be consistent.
5152
let mut helm_release_labels = labels;
5253
helm_release_labels.insert(AGENT_CONTROL_VERSION_SET_FROM.to_string(), source);
5354

0 commit comments

Comments
 (0)