Skip to content

Commit d6e9642

Browse files
committed
feat: improve message of why we avoid some host monitoring generate tests on windows
1 parent 85383bf commit d6e9642

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

agent-control/src/cli/on_host/host_monitoring_gen/infra_config.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ impl Default for InfraConfig {
4646
}
4747

4848
impl InfraConfig {
49-
5049
pub fn with_custom_attributes(mut self, custom_attributes: &str) -> Result<Self, CliError> {
5150
if !custom_attributes.trim().is_empty() {
5251
let custom_attributes_value: serde_yaml::Value =
@@ -251,7 +250,5 @@ config_agent:
251250
#";
252251
let expected_values: serde_yaml::Value = serde_yaml::from_str(expected).unwrap();
253252
assert_eq!(parsed_values, expected_values);
254-
255-
256253
}
257254
}

agent-control/src/cli/on_host/host_monitoring_gen/infra_config_gen.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ pub struct InfraConfigGenerator {
2929
infra_config_path: PathBuf,
3030
}
3131

32-
const INFRA_CONFIG_PATH:&str = "/etc/newrelic-infra.yml";
32+
const INFRA_CONFIG_PATH: &str = "/etc/newrelic-infra.yml";
3333

3434
impl Default for InfraConfigGenerator {
3535
fn default() -> Self {
@@ -202,7 +202,7 @@ agents:
202202

203203
const INFRA_AGENT_VALUES: &str = "fleet/agents.d/infra-test/values/values.yaml";
204204

205-
#[cfg(target_family = "unix")] //TODO This should be removed when Windows support is added
205+
#[cfg(target_family = "unix")] //TODO This should be removed when Windows support is added (DirectoryManager unimplemented)
206206
#[test]
207207
fn test_migrate_old_infra_config() {
208208
// Create a temporary directory
@@ -263,10 +263,9 @@ config_agent:
263263
#";
264264
let expected_values: serde_yaml::Value = serde_yaml::from_str(expected).unwrap();
265265
assert_eq!(parsed_values, expected_values);
266-
267266
}
268267

269-
#[cfg(target_family = "unix")] //TODO This should be removed when Windows support is added
268+
#[cfg(target_family = "unix")] //TODO This should be removed when Windows support is added (DirectoryManager unimplemented)
270269
#[test]
271270
fn test_generate_new_infra_config() {
272271
let temp_dir = TempDir::new().unwrap();

0 commit comments

Comments
 (0)