style: remove unused fields from health checkers (#957)

Author: DavSanchez

agent-control/src/sub_agent/health/k8s/health_checker.rs

@@ -78,7 +78,6 @@ impl SubAgentHealthChecker<K8sHealthChecker> {
                     health_checkers.push(K8sHealthChecker::Flux(K8sHealthFluxHelmRelease::new(
                         k8s_client.clone(),
                         name.clone(),
-                        resource.clone(),
                         start_time,
                     )));
 
@@ -105,7 +104,6 @@ impl SubAgentHealthChecker<K8sHealthChecker> {
                         K8sHealthNRInstrumentation::new(
                             k8s_client.clone(),
                             name.clone(),
-                            resource.clone(),
                             start_time,
                         ),
                     ));

agent-control/src/sub_agent/health/k8s/helm_release.rs

@@ -6,7 +6,6 @@ use crate::sub_agent::health::health_checker::{
 };
 use crate::sub_agent::health::with_start_time::{HealthWithStartTime, StartTime};
 use k8s_openapi::serde_json::{Map, Value};
-use kube::api::DynamicObject;
 use std::sync::Arc;
 
 const CONDITION_READY: &str = "Ready";
@@ -37,21 +36,14 @@ impl From<&str> for ConditionStatus {
 pub struct K8sHealthFluxHelmRelease {
     k8s_client: Arc<SyncK8sClient>,
     name: String,
-    k8s_object: DynamicObject,
     start_time: StartTime,
 }
 
 impl K8sHealthFluxHelmRelease {
-    pub fn new(
-        k8s_client: Arc<SyncK8sClient>,
-        name: String,
-        k8s_object: DynamicObject,
-        start_time: StartTime,
-    ) -> Self {
+    pub fn new(k8s_client: Arc<SyncK8sClient>, name: String, start_time: StartTime) -> Self {
         Self {
             k8s_client,
             name,
-            k8s_object,
             start_time,
         }
     }
@@ -266,7 +258,6 @@ pub mod tests {
             let checker = K8sHealthFluxHelmRelease::new(
                 Arc::new(mock_client),
                 "example-release".to_string(),
-                dynamic_object(),
                 start_time,
             );
             let result = checker.check_health();
@@ -287,14 +278,6 @@ pub mod tests {
         }
     }
 
-    fn dynamic_object() -> DynamicObject {
-        DynamicObject {
-            types: Some(helm_release_type_meta()),
-            metadata: ObjectMeta::default(),
-            data: json!({}),
-        }
-    }
-
     fn setup_mock_client_with_conditions(
         mock: &mut MockSyncK8sClient,
         status_conditions: serde_json::Value,

agent-control/src/sub_agent/health/k8s/instrumentation.rs

@@ -5,7 +5,6 @@ use crate::sub_agent::health::health_checker::{
     Health, HealthChecker, HealthCheckerError, Healthy, Unhealthy,
 };
 use crate::sub_agent::health::with_start_time::{HealthWithStartTime, StartTime};
-use kube::api::DynamicObject;
 use serde::Deserialize;
 use std::fmt::Display;
 use std::sync::Arc;
@@ -109,21 +108,14 @@ impl Display for UnhealthyPodError {
 pub struct K8sHealthNRInstrumentation {
     k8s_client: Arc<SyncK8sClient>,
     name: String,
-    k8s_object: DynamicObject,
     start_time: StartTime,
 }
 
 impl K8sHealthNRInstrumentation {
-    pub fn new(
-        k8s_client: Arc<SyncK8sClient>,
-        name: String,
-        k8s_object: DynamicObject,
-        start_time: StartTime,
-    ) -> Self {
+    pub fn new(k8s_client: Arc<SyncK8sClient>, name: String, start_time: StartTime) -> Self {
         Self {
             k8s_client,
             name,
-            k8s_object,
             start_time,
         }
     }