chore: remove some TODOs (#2058)

Author: DavSanchez

agent-control/src/agent_control/agent_id.rs

@@ -59,7 +59,6 @@ impl Display for AgentID {
 
 impl AsRef<Path> for AgentID {
     fn as_ref(&self) -> &Path {
-        // TODO: define how AgentID should be converted to a Path here.
         Path::new(self.as_str())
     }
 }
@@ -103,7 +102,6 @@ impl Display for SubAgentID {
 
 impl AsRef<Path> for SubAgentID {
     fn as_ref(&self) -> &Path {
-        // TODO: define how SubAgentID should be converted to a Path here.
         Path::new(self.as_str())
     }
 }

agent-control/src/on_host/file_store.rs

@@ -122,20 +122,12 @@ where
         T: DeserializeOwned,
     {
         trace!("Loading data from path '{}'", key.display());
-        self.load_file_if_present(&key)
-            // TODO: Address the generation of this error by
-            // reworking the errors in the `fs` crate so they
-            // emit std::io::Error instead.
-            .map_err(Error::other)
-            .and_then(|maybe_values| {
-                maybe_values
-                    .map(|s| serde_yaml::from_str(&s))
-                    .transpose()
-                    // TODO: Address the generation of this error by
-                    // reworking the errors in the `fs` crate so they
-                    // emit std::io::Error instead.
-                    .map_err(|err| Error::new(ErrorKind::InvalidData, err))
-            })
+        self.load_file_if_present(&key).and_then(|maybe_values| {
+            maybe_values
+                .map(|s| serde_yaml::from_str(&s))
+                .transpose()
+                .map_err(|err| Error::new(ErrorKind::InvalidData, err))
+        })
     }
 }
 

agent-control/src/sub_agent/collection.rs

@@ -30,7 +30,6 @@ where
     }
 
     pub(crate) fn insert(&mut self, agent_id: AgentID, sub_agent: S) -> Option<S> {
-        // TODO: handle error
         self.0.insert(agent_id, sub_agent)
     }