feat(split_namespace): follow up changes (#1414)

Author: paologallinaharbur

agent-control/src/agent_control/config.rs

@@ -500,6 +500,7 @@ k8s:
 
         let k8s = config.k8s.unwrap();
 
+        assert_eq!(k8s.namespace_agents, "some-namespace-agents");
         assert_eq!(k8s.cluster_name, "some-cluster");
         assert_eq!(k8s.namespace, "some-namespace");
     }

agent-control/src/agent_control/resource_cleaner/k8s_garbage_collector.rs

@@ -127,7 +127,7 @@ impl K8sGarbageCollector {
         let labels = obj_meta.labels.as_ref().unwrap_or(&empty_map);
 
         // We delete resources only if they are managed by Agent Control
-        if !labels::is_managed_by_agentcontrol(labels) {
+        if !labels::is_managed_by_agent_control(labels) {
             return Ok(false);
         }
 
@@ -146,11 +146,7 @@ impl K8sGarbageCollector {
 }
 
 impl ResourceCleaner for K8sGarbageCollector {
-    fn clean(
-        &self,
-        id: &AgentID,
-        agent_type_id: &AgentTypeID,
-    ) -> Result<(), super::ResourceCleanerError> {
+    fn clean(&self, id: &AgentID, agent_type_id: &AgentTypeID) -> Result<(), ResourceCleanerError> {
         // Call the collect method to perform garbage collection.
         self.collect(id, agent_type_id)?;
         Ok(())
@@ -195,7 +191,7 @@ impl K8sGarbageCollectorMode<'_> {
                 if let Some(agent_type_id) = agent_identities.get(agent_id) {
                     let annotated_agent_type_id = Self::retrieve_annotated_agent_type_id(obj_meta)?;
                     // Check if the agent type is different from the one in the config.
-                    // This is to support the case where the agent id exists in the config
+                    // This is to support the case where the agent id exists in the config,
                     // but it's a different agent type. See PR#655 for some details.
                     Ok(&annotated_agent_type_id != agent_type_id)
                 } else {

agent-control/src/flags.rs

@@ -45,7 +45,7 @@ pub enum InitError {
 pub enum Command {
     /// Normal operation requested. Get the required config and continue.
     InitAgentControl(AgentControlRunConfig, Vec<TracingGuardBox>),
-    /// Do an "one-shot" operation and exit successfully.
+    /// Do a "one-shot" operation and exit successfully.
     /// In the future, many different operations could be added here.
     OneShot(OneShotCommand),
 }
@@ -143,7 +143,7 @@ impl Flags {
 
             k8s_config: match mode {
                 // This config is not used on the OnHost environment, a blank config is used.
-                // K8sConfig has not default since cluster_name is a required.
+                // K8sConfig has not "default" since cluster_name is a required.
                 Environment::OnHost => K8sConfig::default(),
                 Environment::K8s => agent_control_config.k8s.ok_or(InitError::K8sConfig())?,
             },

agent-control/src/k8s/client.rs

@@ -537,13 +537,8 @@ pub(crate) mod tests {
         let config = Config::new(Uri::try_from("https://localhost.com").unwrap());
         let msg =
             "looks like kube-rs has revisit the timeout, see [DEFAULT_CLIENT_TIMEOUT] for details.";
-        assert_eq!(config.read_timeout, Some(DEFAULT_CLIENT_TIMEOUT), "{}", msg);
-        assert_eq!(
-            config.write_timeout,
-            Some(DEFAULT_CLIENT_TIMEOUT),
-            "{}",
-            msg
-        );
+        assert_eq!(config.read_timeout, Some(DEFAULT_CLIENT_TIMEOUT), "{msg}");
+        assert_eq!(config.write_timeout, Some(DEFAULT_CLIENT_TIMEOUT), "{msg}");
     }
 
     #[tokio::test]

agent-control/src/k8s/error.rs

@@ -28,7 +28,7 @@ pub enum K8sError {
     #[error("the name of the resource is missing")]
     MissingResourceName,
 
-    #[error("the Namespace of the resource is missing")]
+    #[error("the namespace of the resource is missing")]
     MissingResourceNamespace,
 
     #[error("{0} does not have .metadata.name")]

agent-control/src/k8s/labels.rs

@@ -53,7 +53,7 @@ impl Labels {
 }
 
 /// returns true if labels indicates that is managed by the agentControl
-pub fn is_managed_by_agentcontrol(labels: &BTreeMap<String, String>) -> bool {
+pub fn is_managed_by_agent_control(labels: &BTreeMap<String, String>) -> bool {
     labels
         .get(MANAGED_BY_KEY)
         .is_some_and(|v| v == MANAGED_BY_VAL)

agent-control/src/k8s/utils.rs

@@ -240,7 +240,7 @@ pub mod tests {
         impl TestCase {
             fn run(self) {
                 // As we cannot control foreign errors (these errors come from the standard library) we simply test
-                // that it fails but we do not need to know which error.
+                // that it fails, but we do not need to know which error.
                 let _ = IntOrPercentage::try_from(self.int_or_string).inspect(|ok| {
                     panic!(
                         "Test case '{}' should error and did not. Value returned: {}",

agent-control/tests/common/agent_control.rs

@@ -46,7 +46,6 @@ pub fn start_agent_control_with_custom_config(
 
             k8s_config: match mode {
                 // This config is not used on the OnHost environment, a blank config is used.
-                // K8sConfig has not default since cluster_name is a required.
                 Environment::OnHost => K8sConfig::default(),
                 Environment::K8s => {
                     let mut cfg = agent_control_config