Update agent-control/src/cli/on_host/host_monitoring_gen/infra_config_gen.rs

Co-authored-by: danielorihuela <danielorihuela@users.noreply.github.com>

Author: alvarocabanas

agent-control/src/cli/on_host/host_monitoring_gen/infra_config_gen.rs

@@ -131,48 +131,35 @@ impl InfraConfigGenerator {
 
         let legacy_config_renamer = LegacyConfigRenamer::default();
 
-        for cfg in config.configs {
-            debug!("Checking configurations for {}", cfg.agent_type_fqn);
-            match config_migrator.migrate(&cfg) {
-                Ok(_) => {
-                    for (_, mapping_type) in cfg.filesystem_mappings {
-                        match mapping_type {
-                            MappingType::Dir(dir_path) => {
-                                legacy_config_renamer
-                                    .rename_path(dir_path.dir_path.as_path())
-                                    .map_err(|err| {
-                                        CliError::Command(format!(
-                                            "error renaming path on migration: {err}"
-                                        ))
-                                    })?;
-                            }
-                            MappingType::File(file_info) => {
-                                legacy_config_renamer
-                                    .rename_path(file_info.file_path.as_path())
-                                    .map_err(|err| {
-                                        CliError::Command(format!(
-                                            "error renaming file on migration: {err}"
-                                        ))
-                                    })?;
-                            }
-                        }
-                    }
-                    debug!("Classic config files and paths renamed");
-                }
-                Err(MigratorError::AgentTypeNotFoundOnConfig) => {
-                    debug!(
-                        "No agents of agent_type {} found on config, skipping",
-                        cfg.agent_type_fqn.clone()
-                    );
-                }
-                Err(e) => {
-                    warn!(
-                        "Could not apply local config migration for {}: {}",
-                        cfg.agent_type_fqn, e
-                    );
-                }
-            }
-        }
+       for cfg in config.configs {
+           let fqn = cfg.agent_type_fqn.clone();
+           debug!("Checking configurations for {fqn}");
+           let migrate_result = config_migrator.migrate(&cfg);
+           if let Err(MigratorError::AgentTypeNotFoundOnConfig) = migrate_result {
+               debug!("No agents of agent_type {fqn} found on config, skipping",);
+               continue;
+           };
+
+           if let Err(e) = migrate_result {
+               warn!("Could not apply local config migration for {fqn}: {e}",);
+               continue;
+           };
+
+           for (_, mapping_type) in cfg.filesystem_mappings {
+               let (mapping_key, mapping_path) = match mapping_type {
+                   MappingType::Dir(dir_path) => ("path", dir_path.dir_path),
+                   MappingType::File(file_info) => ("file", file_info.file_path),
+               };
+               legacy_config_renamer
+                   .rename_path(mapping_path.as_path())
+                   .map_err(|err| {
+                       CliError::Command(format!(
+                           "error renaming {mapping_key} on migration: {err}"
+                       ))
+                   })?;
+           }
+           debug!("Classic config files and paths renamed");
+       }
         info!("Local config files successfully created");
 
         Ok(())