fix broken tests and add early harvest test for blobs

metal-messiah · metal-messiah · commit a581a7783da1 · 2025-07-29T08:01:34.000-06:00
diff --git a/tests/assets/harvest-early-block-internal.html b/tests/assets/harvest-early-block-internal.html
@@ -8,21 +8,23 @@
     <title>RUM Unit Test</title>
     {init} {config}
     <script>
-      NREUM.init.harvest.interval = 30
+      NREUM.init.harvest.interval = 30;
       NREUM.init.ajax.block_internal = true; // Enable blocking of internal AJAX requests
     </script>
     {loader}
   </head>
-  <body>Instrumented
+  <body>
     <script>
-      // make all events harvest early by setting a jsAttributes size that exceeds the ideal payload size
-      newrelic.setCustomAttribute('foo', 'bar'.repeat(16000))
+      // make all compatible events harvest early by setting a jsAttributes size that exceeds the ideal payload size
+      newrelic.setCustomAttribute("foo", "bar".repeat(16000));
+      newrelic.addPageAction("test");
+      newrelic.log("test");
+      document.addEventListener("click", function () {
+        fetch("https://pokeapi.co/api/v2/pokemon/moltres");
+      });
 
-      newrelic.addPageAction('test')
-      newrelic.log('test')
-      document.addEventListener('click', function () {
-        fetch('https://pokeapi.co/api/v2/pokemon/moltres')
-      })
+      // This will create a trace node with a long name, which should be harvested early
+      newrelic.addToTrace({ name: "foo".repeat(16000), start: Date.now() });
     </script>
   </body>
 </html>
diff --git a/tests/specs/harvesting/harvest-early.e2e.js b/tests/specs/harvesting/harvest-early.e2e.js
@@ -1,17 +1,19 @@
-import { testAjaxEventsRequest, testInsRequest, testInteractionEventsRequest, testLogsRequest } from '../../../tools/testing-server/utils/expect-tests'
+import { testAjaxEventsRequest, testInsRequest, testInteractionEventsRequest, testLogsRequest, testBlobTraceRequest } from '../../../tools/testing-server/utils/expect-tests'
 
 describe('should harvest early', () => {
   let ajaxEventsCapture
   let insightsCapture
   let interactionEventsCapture
   let loggingEventsCapture
+  let testBlobTraceCapture
 
   beforeEach(async () => {
-    [ajaxEventsCapture, insightsCapture, interactionEventsCapture, loggingEventsCapture] = await browser.testHandle.createNetworkCaptures('bamServer', [
+    ;[ajaxEventsCapture, insightsCapture, interactionEventsCapture, loggingEventsCapture, testBlobTraceCapture] = await browser.testHandle.createNetworkCaptures('bamServer', [
       { test: testAjaxEventsRequest },
       { test: testInsRequest },
       { test: testInteractionEventsRequest },
-      { test: testLogsRequest }
+      { test: testLogsRequest },
+      { test: testBlobTraceRequest }
     ])
   })
 
@@ -24,6 +26,7 @@ describe('should harvest early', () => {
       insightsCapture.waitForResult({ totalCount: 1 }),
       interactionEventsCapture.waitForResult({ totalCount: 1 }),
       loggingEventsCapture.waitForResult({ totalCount: 1 }),
+      testBlobTraceCapture.waitForResult({ totalCount: 2 }), // the initial trace ALWAYS harvests immediately, but the second one should be tested for early harvest
       browser.execute(function () {
         document.querySelector('body').click()
       })
diff --git a/tests/specs/session-trace/trace-nodes.e2e.js b/tests/specs/session-trace/trace-nodes.e2e.js
@@ -26,7 +26,7 @@ describe('Trace nodes', () => {
     const [sessionTraceHarvests] = await Promise.all([
       sessionTraceCapture.waitForResult({ timeout: 10000 }),
       browser.execute(function () {
-        const storedEvents = Object.values(newrelic.initializedAgents)[0].features.session_trace.featAggregate.events.prevStoredEvents
+        const storedEvents = Object.values(newrelic.initializedAgents)[0].features.session_trace.featAggregate.traceStorage.prevStoredEvents
         for (let i = 0; i < 10; i++) storedEvents.add(i) // artificially add "events" since the counter is otherwise unreliable
       }).then(() =>
         $('#btn1').click() // since the agent has multiple listeners on vischange, this is a good example of often duplicated event
