Skip to content

Commit cefd898

Browse files
feat: Remove usage of the marks and measures feature flag (#1589)
1 parent c894f40 commit cefd898

File tree

4 files changed

+5
-13
lines changed

4 files changed

+5
-13
lines changed

src/common/config/init.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ const InitModelFn = () => {
2121
const hiddenState = {
2222
feature_flags: [],
2323
experimental: {
24-
marks: false,
25-
measures: false,
2624
resources: false
2725
},
2826
mask_selector: '*',
@@ -72,10 +70,8 @@ const InitModelFn = () => {
7270
page_view_event: { enabled: true, autoStart: true },
7371
page_view_timing: { enabled: true, autoStart: true },
7472
performance: {
75-
get capture_marks () { return hiddenState.feature_flags.includes(FEATURE_FLAGS.MARKS) || hiddenState.experimental.marks },
76-
set capture_marks (val) { hiddenState.experimental.marks = val },
77-
get capture_measures () { return hiddenState.feature_flags.includes(FEATURE_FLAGS.MEASURES) || hiddenState.experimental.measures },
78-
set capture_measures (val) { hiddenState.experimental.measures = val },
73+
capture_marks: false,
74+
capture_measures: false,
7975
capture_detail: true,
8076
resources: {
8177
get enabled () { return hiddenState.feature_flags.includes(FEATURE_FLAGS.RESOURCES) || hiddenState.experimental.resources },

src/features/generic_events/constants.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,5 @@ export const FRUSTRATION_TIMEOUT_MS = 2000
1717
export const RESERVED_EVENT_TYPES = ['PageAction', 'UserAction', 'BrowserPerformance']
1818

1919
export const FEATURE_FLAGS = {
20-
MARKS: 'experimental.marks',
21-
MEASURES: 'experimental.measures',
2220
RESOURCES: 'experimental.resources'
2321
}

tests/specs/ins/harvesting.e2e.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ describe('ins harvesting', () => {
7676
})
7777

7878
;[
79-
[getInsInit({ performance: { capture_marks: true } }), 'enabled'],
80-
[getInsInit({ performance: { capture_marks: false }, feature_flags: [FEATURE_FLAGS.MARKS] }), 'feature flag']
79+
[getInsInit({ performance: { capture_marks: true } }), 'enabled']
8180
].forEach(([insInit, type]) => {
8281
it('should submit Marks - ' + type, async () => {
8382
const testUrl = await browser.testHandle.assetURL('marks-and-measures.html', insInit)
@@ -108,8 +107,7 @@ describe('ins harvesting', () => {
108107
})
109108

110109
;[
111-
[getInsInit({ performance: { capture_measures: true } }), 'enabled'],
112-
[getInsInit({ performance: { capture_measures: false }, feature_flags: [FEATURE_FLAGS.MEASURES] }), 'feature flag']
110+
[getInsInit({ performance: { capture_measures: true } }), 'enabled']
113111
].forEach(([insInit, type]) => {
114112
it('should submit Measures - ' + type, async () => {
115113
const testUrl = await browser.testHandle.assetURL('marks-and-measures.html', insInit)

tools/test-builds/rollup-micro-agent/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"license": "ISC",
1313
"type": "commonjs",
1414
"dependencies": {
15-
"@newrelic/browser-agent": "file:../../../temp/newrelic-browser-agent-1.298.0.tgz"
15+
"@newrelic/browser-agent": "file:../../../temp/newrelic-browser-agent-1.299.0.tgz"
1616
},
1717
"devDependencies": {
1818
"@rollup/plugin-commonjs": "^28.0.6",

0 commit comments

Comments
 (0)