Skip to content

Commit 5181dc9

Browse files
Add verbose logging and update AWS secrets to V2 variants
Co-authored-by: pranav-new-relic <127438038+pranav-new-relic@users.noreply.github.com>
1 parent 6446c78 commit 5181dc9

1 file changed

Lines changed: 21 additions & 18 deletions

File tree

.github/workflows/release.yml

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ jobs:
6161
path: /home/runner/.aws/credentials
6262
contents: |
6363
[virtuoso_user]
64-
aws_access_key_id=${{ secrets.AWS_ACCESS_KEY_ID }}
65-
aws_secret_access_key=${{ secrets.AWS_SECRET_ACCESS_KEY }}
64+
aws_access_key_id=${{ secrets.AWS_ACCESS_KEY_ID_V2 }}
65+
aws_secret_access_key=${{ secrets.AWS_SECRET_ACCESS_KEY_V2 }}
6666
write-mode: overwrite
6767

6868
- name: Write AWS config 2
@@ -71,36 +71,39 @@ jobs:
7171
path: /home/runner/.aws/config
7272
contents: |
7373
[profile virtuoso]
74-
role_arn = ${{ secrets.AWS_ROLE_ARN }}
74+
role_arn = ${{ secrets.AWS_ROLE_ARN_V2 }}
7575
region = ${{ secrets.AWS_DEFAULT_REGION }}
7676
source_profile = virtuoso_user
7777
write-mode: overwrite
7878

79-
- name: Check S3 bucket permissions
79+
- name: Verify AWS credentials for release artifact distribution to S3
8080
run: |
8181
set -e
82-
echo "Verifying AWS credentials and S3 bucket permissions before release..."
82+
echo "🔐 Verifying AWS credentials and S3 bucket access..."
83+
echo "📦 Target bucket: s3://nr-downloads-main/install/newrelic-cli/"
8384
84-
# Test if we can list the bucket (requires s3:ListBucket permission)
85-
if ! aws s3 ls s3://nr-downloads-main/install/newrelic-cli/ --profile virtuoso; then
86-
echo "::error::Failed to list S3 bucket. Please check AWS credentials and permissions."
85+
echo "🔍 Testing S3 ListBucket permission..."
86+
if ! aws s3 ls s3://nr-downloads-main/install/newrelic-cli/ --profile virtuoso > /dev/null 2>&1; then
87+
echo "::error::Failed to list S3 bucket. Please verify AWS credentials and s3:ListBucket permission."
8788
exit 1
8889
fi
90+
echo "✅ ListBucket permission verified"
8991
90-
# Create a test file to verify write permissions
92+
echo "📝 Creating test file for upload verification..."
9193
echo "test-permission-check" > /tmp/test-permission.txt
9294
93-
# Test if we can upload a file (requires s3:PutObject permission)
94-
if ! aws s3 cp /tmp/test-permission.txt s3://nr-downloads-main/install/newrelic-cli/.permission-check-test.txt --profile virtuoso; then
95-
echo "::error::Failed to upload to S3 bucket. Please verify s3:PutObject permission is granted."
95+
echo "⬆️ Testing S3 PutObject permission..."
96+
if ! aws s3 cp /tmp/test-permission.txt s3://nr-downloads-main/install/newrelic-cli/.permission-check-test.txt --profile virtuoso > /dev/null 2>&1; then
97+
echo "::error::Failed to upload to S3 bucket. Please verify s3:PutObject permission."
9698
exit 1
9799
fi
100+
echo "✅ PutObject permission verified"
98101
99-
# Clean up test file from S3
100-
aws s3 rm s3://nr-downloads-main/install/newrelic-cli/.permission-check-test.txt --profile virtuoso || true
102+
echo "🧹 Cleaning up test artifacts..."
103+
aws s3 rm s3://nr-downloads-main/install/newrelic-cli/.permission-check-test.txt --profile virtuoso > /dev/null 2>&1 || true
101104
rm -f /tmp/test-permission.txt
102105
103-
echo " AWS S3 permissions verified successfully!"
106+
echo " AWS S3 permissions validated successfully - ready for release artifact distribution!"
104107
105108
- name: Publish Release
106109
shell: bash
@@ -276,9 +279,9 @@ jobs:
276279
RELEASE_TOKEN: ${{ secrets.RELEASE_TOKEN }}
277280
DEV_TOOLKIT_TOKEN: ${{ secrets.DEV_TOOLKIT_TOKEN }}
278281
CHOCOLATEY_API_KEY: ${{ secrets.CHOCOLATEY_API_KEY }}
279-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
280-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
281-
AWS_ROLE_ARN: ${{ secrets.AWS_ROLE_ARN }}
282+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID_V2 }}
283+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY_V2 }}
284+
AWS_ROLE_ARN: ${{ secrets.AWS_ROLE_ARN_V2 }}
282285
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
283286

284287
snapshot:

0 commit comments

Comments
 (0)