Skip to content

Commit 488ace7

Browse files
test(entities): adds test cases to test errors with reserved keys modified in entity tags (#1188)
1 parent fb8f11c commit 488ace7

File tree

1 file changed

+40
-2
lines changed

1 file changed

+40
-2
lines changed

pkg/entities/tags_integration_test.go

+40-2
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
package entities
55

66
import (
7-
"testing"
8-
97
"github.com/stretchr/testify/require"
8+
"regexp"
9+
"testing"
1010

1111
"github.com/newrelic/newrelic-client-go/v2/pkg/common"
1212
"github.com/newrelic/newrelic-client-go/v2/pkg/testhelpers"
@@ -61,6 +61,7 @@ func TestIntegrationTaggingAddTagsToEntityAndGetTags(t *testing.T) {
6161

6262
require.NoError(t, err)
6363
require.Greater(t, len(actual), 0)
64+
6465
}
6566

6667
func TestIntegrationTaggingReplaceTagsOnEntity(t *testing.T) {
@@ -83,6 +84,7 @@ func TestIntegrationTaggingReplaceTagsOnEntity(t *testing.T) {
8384
require.NoError(t, err)
8485
require.NotNil(t, result)
8586
require.Equal(t, 0, len(result.Errors))
87+
8688
}
8789

8890
func TestIntegrationDeleteTags(t *testing.T) {
@@ -123,3 +125,39 @@ func TestIntegrationDeleteTagValues(t *testing.T) {
123125
require.NotNil(t, result)
124126
require.Equal(t, 0, len(result.Errors))
125127
}
128+
129+
func TestIntegrationEntityTagsReservedKeysMutation(t *testing.T) {
130+
t.Parallel()
131+
132+
var (
133+
testGUID = common.EntityGUID(testhelpers.IntegrationTestApplicationEntityGUID)
134+
)
135+
136+
client := newIntegrationTestClient(t)
137+
138+
// Test: To add a reserved key(immutable key)
139+
tags := []TaggingTagInput{
140+
{
141+
Key: "account",
142+
Values: []string{"Random-name"},
143+
},
144+
}
145+
result, err := client.TaggingAddTagsToEntity(testGUID, tags)
146+
require.NoError(t, err)
147+
require.NotNil(t, result)
148+
require.Greater(t, len(result.Errors), 0)
149+
message := result.Errors[0].Message
150+
match, er := regexp.MatchString("reserved", message)
151+
require.NoError(t, er)
152+
require.True(t, match)
153+
154+
// Test: To update a reserved key(immutable key)
155+
result, err = client.TaggingReplaceTagsOnEntity(testGUID, tags)
156+
require.NoError(t, err)
157+
require.NotNil(t, result)
158+
require.Greater(t, len(result.Errors), 0)
159+
message = result.Errors[0].Message
160+
match, er = regexp.MatchString("reserved", message)
161+
require.NoError(t, er)
162+
require.True(t, match)
163+
}

0 commit comments

Comments
 (0)