chore: Fixing integration tests

Author: daffinito

dockerHelper_test.go

@@ -4,10 +4,20 @@ import (
 	"os"
 	"os/exec"
 	"runtime"
+	"strings"
+	"time"
 
 	log "github.com/newrelic/newrelic-diagnostics-cli/logger"
 )
 
+// dockerBuildRetryPatterns are transient errors seen on Windows CI runners
+// that are worth retrying rather than failing the whole test.
+var dockerBuildRetryPatterns = []string{
+	"hcs::CreateComputeSystem",
+	"failed to connect to the docker API",
+	"docker_engine",
+}
+
 func CreateDockerImage(imageName string, dockerFROM string, docker_cmd string, dockerLines []string) error {
 
 	//Create the Dockerfile
@@ -19,14 +29,21 @@ func CreateDockerImage(imageName string, dockerFROM string, docker_cmd string, d
 
 	log.Debug("Running docker build -f integrationDockerfile -t ", imageName, " .")
 
-	buildArgs := []string{"build"}
-	if runtime.GOOS == "windows" {
-		buildArgs = append(buildArgs, "--isolation=hyperv")
+	const maxAttempts = 3
+	var output []byte
+	var cmdBuildErr error
+	for attempt := 1; attempt <= maxAttempts; attempt++ {
+		cmdBuild := exec.Command("docker", "build", "-f", dockerfile, "-t", imageName, ".")
+		output, cmdBuildErr = cmdBuild.CombinedOutput()
+		if cmdBuildErr == nil {
+			break
+		}
+		if attempt == maxAttempts || !isTransientDockerError(string(output)) {
+			break
+		}
+		log.Info("Transient docker build error for ", imageName, " (attempt ", attempt, " of ", maxAttempts, "), retrying in ", attempt*5, "s")
+		time.Sleep(time.Duration(attempt*5) * time.Second)
 	}
-	buildArgs = append(buildArgs, "-f", dockerfile, "-t", imageName, ".")
-	cmdBuild := exec.Command("docker", buildArgs...)
-
-	output, cmdBuildErr := cmdBuild.CombinedOutput()
 
 	if cmdBuildErr != nil {
 		log.Info("Error running docker build -", cmdBuildErr)
@@ -37,6 +54,15 @@ func CreateDockerImage(imageName string, dockerFROM string, docker_cmd string, d
 	return nil
 }
 
+func isTransientDockerError(output string) bool {
+	for _, pattern := range dockerBuildRetryPatterns {
+		if strings.Contains(output, pattern) {
+			return true
+		}
+	}
+	return false
+}
+
 // CreateDockerfile - This builds the raw Dockerfile from the slice of tests
 func CreateDockerfile(imageName string, dockerFROM string, dockerCMD string, dockerfileLines []string) (string, error) {
 	f, _ := os.CreateTemp("temp", imageName)
@@ -120,9 +146,6 @@ func RunDockerContainer(imageName string, hostsAdditions []string) (string, erro
 	//Create docker container based on test name
 
 	args := []string{"run", "--rm"}
-	if runtime.GOOS == "windows" {
-		args = append(args, "--isolation=hyperv")
-	}
 	if len(hostsAdditions) > 0 {
 		for _, hostAddition := range hostsAdditions {
 			args = append(args, "--add-host", hostAddition)