Skip to content

Commit 759c612

Browse files
committed
Update dotty, test csproj files, and add comments about attributes.
1 parent cde6d84 commit 759c612

4 files changed

Lines changed: 13 additions & 9 deletions

File tree

build/Dotty/packageInfo.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
{
1515
"packageName": "amazon.lambda.kinesisevents",
16-
"ignoreTFMs" : "net8.0",
16+
"ignoreTFMs": "net8.0",
1717
"ignoreReason": "net8.0 tests 2.x.x version"
1818
},
1919
{
@@ -76,6 +76,10 @@
7676
"ignoreTFMs": "net8.0",
7777
"ignoreReason": "net8.0 tests 2.x.x version"
7878
},
79+
80+
{
81+
"packageName": "hangfire"
82+
},
7983
{
8084
"packageName": "log4net"
8185
},

src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/Hangfire/HangfirePerformerWrapper.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public AfterWrappedMethodDelegate BeforeWrappedMethod(InstrumentedMethodCall ins
6161
var segmentName = string.IsNullOrWhiteSpace(queueName) ? "Hangfire/" + taskName : "Hangfire/Queue/Consume/Named/" + queueName + "/" + taskName;
6262
var segment = transaction.StartTransactionSegment(instrumentedMethodCall.MethodCall, segmentName);
6363

64+
// These attributes are based on a suggested OTel semantic convention for for workflows - itself based on AI workflow conventions.
6465
segment.AddAgentAttribute("workflow.platform.name", "hangfire");
6566
segment.AddAgentAttribute("workflow.task.name", taskName);
6667
segment.AddAgentAttribute("workflow.task.id", jobId);

tests/Agent/IntegrationTests/SharedApplications/Common/MFALatestPackages/MFALatestPackages.csproj

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@
2020
<PackageReference Include="Elastic.Clients.Elasticsearch" Version="9.0.7" Condition="'$(TargetFramework)' == 'net10.0'" />
2121
<PackageReference Include="Elasticsearch.Net" Version="7.17.5" Condition="'$(TargetFramework)' == 'net481'" />
2222
<PackageReference Include="Elasticsearch.Net" Version="7.17.5" Condition="'$(TargetFramework)' == 'net10.0'" />
23+
<PackageReference Include="Hangfire" Version="1.8.23" Condition="'$(TargetFramework)' == 'net481'" />
24+
<PackageReference Include="Hangfire" Version="1.8.23" Condition="'$(TargetFramework)' == 'net10.0'" />
25+
<PackageReference Include="Hangfire.InMemory" Version="1.0.0" Condition="'$(TargetFramework)' == 'net481'" />
26+
<PackageReference Include="Hangfire.InMemory" Version="1.0.0" Condition="'$(TargetFramework)' == 'net10.0'" />
27+
<!-- Hangfire.SqlServer is excluded from all target frameworks because we aren't using it, and it has a dependency on System.Data.SqlClient that causes problems for NServiceBus -->
28+
<PackageReference Include="Hangfire.SqlServer" Version="1.8.23" ExcludeAssets="all" PrivateAssets="all" Condition="'$(TargetFramework)' == 'net481'" />
29+
<PackageReference Include="Hangfire.SqlServer" Version="1.8.23" ExcludeAssets="all" PrivateAssets="all" Condition="'$(TargetFramework)' == 'net10.0'" />
2330
<PackageReference Include="LibGit2Sharp" Version="0.31.0" Condition="'$(TargetFramework)' == 'net481'" />
2431
<PackageReference Include="LibGit2Sharp" Version="0.31.0" Condition="'$(TargetFramework)' == 'net10.0'" />
2532
<PackageReference Include="LibGit2Sharp.NativeBinaries" Version="2.0.323" Condition="'$(TargetFramework)' == 'net481'" />

tests/Agent/IntegrationTests/SharedApplications/Common/MultiFunctionApplicationHelpers/MultiFunctionApplicationHelpers.csproj

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -346,17 +346,9 @@
346346
<PackageReference Include="Hangfire" Version="1.7.15" Condition="'$(TargetFramework)' == 'net8.0'" />
347347
<PackageReference Include="Hangfire.InMemory" Version="0.11.0" Condition="'$(TargetFramework)' == 'net8.0'" />
348348

349-
<PackageReference Include="Hangfire" Version="1.8.23" Condition="'$(TargetFramework)' == 'net481'" />
350-
<PackageReference Include="Hangfire.InMemory" Version="1.0.0" Condition="'$(TargetFramework)' == 'net481'" />
351-
352-
<PackageReference Include="Hangfire" Version="1.8.23" Condition="'$(TargetFramework)' == 'net10.0'" />
353-
<PackageReference Include="Hangfire.InMemory" Version="1.0.0" Condition="'$(TargetFramework)' == 'net10.0'" />
354-
355349
<!-- Hangfire.SqlServer is excluded from all target frameworks because we aren't using it, and it has a dependency on System.Data.SqlClient that causes problems for NServiceBus -->
356350
<PackageReference Include="Hangfire.SqlServer" Version="1.7.15" ExcludeAssets="all" PrivateAssets="all" Condition="'$(TargetFramework)' == 'net462'" />
357351
<PackageReference Include="Hangfire.SqlServer" Version="1.7.15" ExcludeAssets="all" PrivateAssets="all" Condition="'$(TargetFramework)' == 'net8.0'" />
358-
<PackageReference Include="Hangfire.SqlServer" Version="1.8.23" ExcludeAssets="all" PrivateAssets="all" Condition="'$(TargetFramework)' == 'net481'" />
359-
<PackageReference Include="Hangfire.SqlServer" Version="1.8.23" ExcludeAssets="all" PrivateAssets="all" Condition="'$(TargetFramework)' == 'net10.0'" />
360352
</ItemGroup>
361353

362354
<ItemGroup>

0 commit comments

Comments
 (0)