Skip to content

Commit cea14e8

Browse files
authored
test: Update AspNetCoreMvcCoreFrameworkApplication to ASP.NET Core 2.3 (#3525)
Update AspNetCoreMvcCoreFrameworkApplication to ASP.NET Core 2.3
1 parent 0e78da3 commit cea14e8

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

tests/Agent/IntegrationTests/Applications/AspNetCoreMvcCoreFrameworkApplication/AspNetCoreMvcCoreFrameworkApplication.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
</ItemGroup>
1010

1111
<ItemGroup>
12-
<PackageReference Include="Microsoft.AspNetCore" Version="2.1.7" />
13-
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.1.3" />
12+
<PackageReference Include="Microsoft.AspNetCore" Version="2.3.9" />
13+
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.3.9" />
1414
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15">
1515
<PrivateAssets>all</PrivateAssets>
1616
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

tests/Agent/IntegrationTests/Applications/AspNetCoreMvcCoreFrameworkApplication/Startup.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ public void ConfigureServices(IServiceCollection services)
2525
services
2626
.AddMvcCore()
2727
.AddJsonFormatters()
28+
// Despite this application now using a 2.3 version of ASP.NET Core,
29+
// 2.1 is still an appropriate compatibility version to use for this application,
30+
// since 2.3 is just a reshipping of 2.1. See Microsoft's announcement of
31+
// ASP.NET Core 2.3 for more details: https://github.com/dotnet/announcements/issues/331
2832
.SetCompatibilityVersion(CompatibilityVersion.Version_2_1);
2933
}
3034

@@ -38,4 +42,4 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env)
3842

3943
app.UseMvc();
4044
}
41-
}
45+
}

0 commit comments

Comments
 (0)