Skip to content

Commit 1efe786

Browse files
NR-359272: fix NRMAURLSessionTaskOverride to not check responseCode.
1 parent 0b1a8a4 commit 1efe786

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,6 @@ + (void) deinstrument
8585
}
8686
}
8787

88-
+ (NSInteger) statusCode:(NSURLResponse*)response {
89-
return [response isKindOfClass:[NSHTTPURLResponse class]] ? [((NSHTTPURLResponse*)response) statusCode] : -1;
90-
}
91-
9288
// Currently we support NSURLSessionDataTask, NSURLSessionDownloadTask, and NSURLSessionUploadTask.
9389
+ (bool) isSupportedTaskType:(NSURLSessionTask*) task {
9490
return [task isKindOfClass:[NSURLSessionDataTask class]] || [task isKindOfClass:[NSURLSessionDownloadTask class]] || [task isKindOfClass:[NSURLSessionUploadTask class]];
@@ -137,12 +133,8 @@ void NRMAOverride__urlSessionTask_SetState(NSURLSessionTask* task, SEL _cmd, NSU
137133
[NRMAHTTPUtilities attachPayload:payload
138134
to:task.originalRequest];
139135

140-
// get response code
141-
NSUInteger responseCode = [NRMAURLSessionTaskOverride statusCode:task.response];
142-
if (responseCode != -1) {
143-
NSData *data = NRMA__getDataForSessionTask(task);
144-
NRMA__recordTask(task, data, task.response, task.error);
145-
}
136+
NSData *data = NRMA__getDataForSessionTask(task);
137+
NRMA__recordTask(task, data, task.response, task.error);
146138
}
147139
}
148140
}

0 commit comments

Comments
 (0)