NR-359272: fix NRMAURLSessionTaskOverride to not check responseCode.

newrelic · Jan 16, 2025 · 1efe786 · 1efe786
1 parent 0b1a8a4
commit 1efe786
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m b/Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m
@@ -85,10 +85,6 @@ + (void) deinstrument
     }
 }
 
-+ (NSInteger) statusCode:(NSURLResponse*)response {
-    return [response isKindOfClass:[NSHTTPURLResponse class]] ? [((NSHTTPURLResponse*)response) statusCode] : -1;
-}
-
 // Currently we support NSURLSessionDataTask, NSURLSessionDownloadTask, and NSURLSessionUploadTask.
 + (bool) isSupportedTaskType:(NSURLSessionTask*) task {
     return [task isKindOfClass:[NSURLSessionDataTask class]] || [task isKindOfClass:[NSURLSessionDownloadTask class]] || [task isKindOfClass:[NSURLSessionUploadTask class]];
@@ -137,12 +133,8 @@ void NRMAOverride__urlSessionTask_SetState(NSURLSessionTask* task, SEL _cmd, NSU
                     [NRMAHTTPUtilities attachPayload:payload
                                                   to:task.originalRequest];
 
-                    // get response code
-                    NSUInteger responseCode = [NRMAURLSessionTaskOverride statusCode:task.response];
-                    if (responseCode != -1) {
-                        NSData *data = NRMA__getDataForSessionTask(task);
-                        NRMA__recordTask(task, data, task.response, task.error);
-                    }
+                    NSData *data = NRMA__getDataForSessionTask(task);
+                    NRMA__recordTask(task, data, task.response, task.error);
                 }
             }
         }