From 1efe786c477f3133c5cb7cace33261448a8dcc24 Mon Sep 17 00:00:00 2001 From: Chris Dillard Date: Thu, 16 Jan 2025 15:50:21 -0700 Subject: [PATCH] NR-359272: fix NRMAURLSessionTaskOverride to not check responseCode. --- .../NSURLSession/NRMAURLSessionTaskOverride.m | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m b/Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m index 585d7282..b70e9d91 100644 --- a/Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m +++ b/Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m @@ -85,10 +85,6 @@ + (void) deinstrument } } -+ (NSInteger) statusCode:(NSURLResponse*)response { - return [response isKindOfClass:[NSHTTPURLResponse class]] ? [((NSHTTPURLResponse*)response) statusCode] : -1; -} - // Currently we support NSURLSessionDataTask, NSURLSessionDownloadTask, and NSURLSessionUploadTask. + (bool) isSupportedTaskType:(NSURLSessionTask*) task { return [task isKindOfClass:[NSURLSessionDataTask class]] || [task isKindOfClass:[NSURLSessionDownloadTask class]] || [task isKindOfClass:[NSURLSessionUploadTask class]]; @@ -137,12 +133,8 @@ void NRMAOverride__urlSessionTask_SetState(NSURLSessionTask* task, SEL _cmd, NSU [NRMAHTTPUtilities attachPayload:payload to:task.originalRequest]; - // get response code - NSUInteger responseCode = [NRMAURLSessionTaskOverride statusCode:task.response]; - if (responseCode != -1) { - NSData *data = NRMA__getDataForSessionTask(task); - NRMA__recordTask(task, data, task.response, task.error); - } + NSData *data = NRMA__getDataForSessionTask(task); + NRMA__recordTask(task, data, task.response, task.error); } } }