Improve consistency in PHP version ifdef usage

[joshuabenuck]

Summary

The version specific PHP ifdefs should refer to the named version only and not the named version or higher.

Desired Behavior

PHP7 should only refer to PHP version 7, not version 8 in order to be consistent with the PHP5 and PHP8 ifdefs.

Possible Solution

We may also want to consider adding something like a PHP7_PLUS ifdef in order to avoid the more complex zend module version comparison ifdef used now.

Additional context

PR #49 is where the PHP8 ifdef was first added and when the inconsistency was introduced (since there is now a version greater than PHP 7.x).

[Miriam-R]

Part of #34 Agent Tests

[zsistla]

Unless there is a specific ZEND_8_0_X_API_NO or another ZEND_7_x_API_NO block,

Change #ifdef PHP7

to be:
#if ZEND_MODULE_API_NO >= ZEND_7_0_X_API_NO /* PHP 7.0+ */

This will avoid confusion and increase clarity because the majority of those blocks also apply to PHP8.

[insanebits]

Is there any progress on this?

[zsistla]

Hello @insanebits, and thank you for your interest! This issue is in our backlog to be worked on, but currently has no scheduled date.