Supportability metrics for dropped events

Author: lrafeei

newrelic/api/time_trace.py

@@ -226,6 +226,7 @@ def _add_span_link_event(self, span_id, trace_id, linked_span_id, linked_trace_i
             return
 
         if len(self.span_link_events) >= 100:
+            self.transaction._record_supportability("Supportability/SpanEvent/Links/Dropped")
             _logger.debug(
                 "Maximum number of SpanLink events already added. Dropping SpanLink event: linkedSpanId=%r, linkedTraceId=%r",
                 linked_span_id,
@@ -258,6 +259,7 @@ def _add_span_event_event(self, name, span_id, trace_id, timestamp=None, attribu
             return
 
         if len(self.span_event_events) >= 100:
+            self.transaction._record_supportability("Supportability/SpanEvent/Events/Dropped")
             _logger.debug(
                 "Maximum number of SpanEvent events already added. Dropping SpanEvent event: name=%r, spanId=%r, traceId=%r",
                 name,

tests/hybridagent_opentelemetry/test_spanevent_spanlinks.py

@@ -16,6 +16,7 @@
 from opentelemetry.trace import Link, SpanContext, TraceState
 from testing_support.fixtures import dt_enabled
 from testing_support.validators.validate_spanlink_spanevent_events import validate_spanlink_or_spanevent_events
+from testing_support.validators.validate_transaction_metrics import validate_transaction_metrics
 
 from newrelic.api.background_task import background_task
 
@@ -162,3 +163,60 @@ def _test():
             otel_span.add_event("otelevent", attributes={"key99": "value99", "universe": 42})
 
     _test()
+
+
+@dt_enabled
+@validate_spanlink_or_spanevent_events(
+    count=100,
+    exact_intrinsics={"name": "otelevent", "type": "SpanEvent"},
+    expected_intrinsics=["timestamp", "span.id", "trace.id", "name"],
+    exact_users={"key1": "value1", "key2": 42},
+)
+@validate_transaction_metrics(
+    "test_spanevent_spanlinks:test_spanevent_events_over_limit.<locals>._test",
+    rollup_metrics=[
+        ("Supportability/SpanEvent/Events/Dropped", 3),
+    ],
+    background_task=True,
+)
+def test_spanevent_events_over_limit(tracer):
+    @background_task()
+    def _test():
+        with tracer.start_as_current_span("otelspan") as otel_span:
+            for _ in range(103):
+                otel_span.add_event("otelevent", attributes={"key1": "value1", "key2": 42})
+
+    _test()
+
+
+@dt_enabled
+@validate_spanlink_or_spanevent_events(
+    count=100,
+    exact_intrinsics={
+        "type": "SpanLink",
+    },
+    expected_intrinsics=["timestamp", "id", "trace.id", "linkedSpanId", "linkedTraceId"],
+    exact_users={"key1": "value1", "key2": 42},
+)
+@validate_transaction_metrics(
+    "test_spanevent_spanlinks:test_spanlink_events_over_limit.<locals>._test",
+    rollup_metrics=[
+        ("Supportability/SpanEvent/Links/Dropped", 3),
+    ],
+    background_task=True,
+)
+def test_spanlink_events_over_limit(tracer):  
+    @background_task()
+    def _test():
+        with tracer.start_as_current_span("otelspan") as otel_span:
+            for incrementer in range(103):
+                linked_span_context = SpanContext(
+                    trace_id=0x1234567890ABCDEF1234567890ABCDEF + incrementer,
+                    span_id=0x1234567890ABCDEF + incrementer,
+                    is_remote=True,
+                    trace_flags=0x01,
+                    trace_state=TraceState(),
+                )  
+                otel_span.add_link(linked_span_context, attributes={"key1": "value1", "key2": 42})
+
+    _test()