return in finally swallows exceptions

[iritkatriel]

In

newrelic-python-agent/tests/framework_aiohttp/_target_application.py

Line 97 in 7d6da2c

return web.Response(text="Hello Aiohttp!")

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

If the intention is to suppress all exceptions, I would propose to make this clear by using "except BaseException".

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

[workato-integration]

https://new-relic.atlassian.net/browse/NR-333082