fix: incorporate Jest 29 compatibility and API updates from PR #2763

- Add jest.setup.js with @actions/core mock for test isolation
- Add setupFiles config to jest.config.js
- Fix cockatiel retry API order (.exponential().attempts() instead of .attempts().exponential())
- Fix github-api-helpers.ts response handling (check resp.ok before parsing JSON)
- Add .sort() to glob results in Alert.ts for deterministic ordering
- Update Jest assertions for v29 compatibility:
  - toBeCalled -> toHaveBeenCalled
  - toBeCalledTimes -> toHaveBeenCalledTimes
- Update fs mock in validate_images.test.js to use jest.requireActual

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: praveenkatha-nr

utils/__tests__/set-dashboard-required-datasources.test.js

@@ -127,6 +127,6 @@ describe('set-dashboards-required-datasources', () => {
       `Multiple Quickstart data sources detected for Quickstart: Template Quickstart, Dashboards must be updated manually`
     );
 
-    expect(Dashboard.submitSetRequiredDataSourcesMutation).not.toBeCalled();
+    expect(Dashboard.submitSetRequiredDataSourcesMutation).not.toHaveBeenCalled();
   });
 });

utils/__tests__/validate_icon.test.js

@@ -137,7 +137,7 @@ describe('validate Icon tests', () => {
 
       handleErrors(['error1', 'error2', 'error3', 'error4']);
 
-      expect(logMock).toBeCalledTimes(4);
+      expect(logMock).toHaveBeenCalledTimes(4);
     });
   });
 });

utils/__tests__/validate_images.test.js

@@ -10,8 +10,8 @@ import * as fs from 'fs';
 import * as glob from 'glob';
 import * as path from 'path';
 
-jest.mock('@actions/core');
 jest.mock('fs', () => ({
+  ...jest.requireActual('fs'),
   promises: {
     access: jest.fn(),
   },

utils/jest.config.js

@@ -5,4 +5,5 @@ module.exports = {
   testRegex: '(/__tests__/.*\\.(test|spec))\\.(ts|js)$',
   moduleFileExtensions: ['js', 'ts', 'json'],
   transformIgnorePatterns: ['.json'],
+  setupFiles: ['<rootDir>/jest.setup.js'],
 };

utils/jest.setup.js

@@ -0,0 +1,12 @@
+// Jest setup file for mocking external dependencies
+
+// Mock @actions/core to prevent GitHub Actions side effects during tests
+jest.mock('@actions/core', () => ({
+  setFailed: jest.fn(),
+  warning: jest.fn(),
+  info: jest.fn(),
+  debug: jest.fn(),
+  error: jest.fn(),
+  getInput: jest.fn(),
+  setOutput: jest.fn(),
+}));

utils/lib/Alert.ts

@@ -342,7 +342,7 @@ class Alert extends Component<
   static getAll() {
     const alertPaths = glob.sync(
       path.join(__dirname, '..', '..', 'alert-policies', '**', '*.+(yml|yaml)')
-    );
+    ).sort();
     return alertPaths.map((alertPath) => {
       // The identifier for alerts is the folder and the file name
       // e.g. `node-js/HighCpuUtilization.yml`

utils/lib/__tests__/Dashboard.test.js

@@ -54,7 +54,7 @@ describe('Dashboard', () => {
       );
       expect(dash.isValid).toBe(false);
       expect(dash.config).not.toBeDefined();
-      expect(console.error).toBeCalled();
+      expect(console.error).toHaveBeenCalled();
     });
   });
 
@@ -73,15 +73,15 @@ describe('Dashboard', () => {
       );
       expect(dash.configPath).toEqual('');
       expect(dash.isValid).toBe(false);
-      expect(console.error).toBeCalled();
+      expect(console.error).toHaveBeenCalled();
     });
 
     test('Fails to create valid config path, basePath is invalid', () => {
       jest.spyOn(global.console, 'error').mockImplementation(() => {});
       const dash = new Dashboard('mock-dashboard-2', __dirname);
       expect(dash.configPath).toEqual('');
       expect(dash.isValid).toBe(false);
-      expect(console.error).toBeCalled();
+      expect(console.error).toHaveBeenCalled();
     });
   });
 

utils/lib/github-api-helpers.ts

@@ -66,17 +66,17 @@ export const fetchPaginatedGHResults = async (
       const resp = await fetch(nextPageLink, {
         headers,
       });
-      // TODO: this should happen after the resp.ok check
-      const responseJson = await resp.json();
 
       if (!resp.ok) {
         logger.error(`Error from Github API`, {
           url: nextPageLink,
           status: resp.statusText,
           code: resp.status,
         });
-        throw new Error(`Github API returned: ${responseJson.message}`);
+        const errorJson = await resp.json();
+        throw new Error(`Github API returned: ${errorJson.message}`);
       }
+      const responseJson = await resp.json();
       nextPageLink = getNextLink(resp.headers.get('Link'));
       files = [...files, ...responseJson];
     }

utils/lib/nr-graphql-helpers.ts

@@ -52,20 +52,20 @@ export const fetchNRGraphqlResults = async <Variables, ResponseData>(
   // To help us ensure that the request hits and is processed by nerdgraph
   // This will try the request 3 times, waiting a little longer between each attempt
   // It will retry on status codes 400+, 2** would be success and we wouldn't want to retry for a 3**
-  const retry = Policy.handleResultType(
+  const retryPolicy = Policy.handleResultType(
     Response,
     (response) => response.status >= 400
   )
     .retry()
-    .attempts(3)
-    .exponential();
+    .exponential()
+    .attempts(3);
 
   try {
     const body = buildRequestBody<Variables>(queryBody);
 
     logger.debug(`Running NerdGraph request...`, { url: NR_API_URL, body });
 
-    const res = await retry.execute(() =>
+    const res = await retryPolicy.execute(() =>
       fetch(NR_API_URL, {
         method: 'POST',
         body,