Comment cleanup

Author: kaylareopelle

lib/new_relic/agent/opentelemetry_handler.rb

@@ -5,10 +5,10 @@
 module NewRelic
   module Agent
     class OpenTelemetryHandler
-      # TODO: should you be a singleton? should you be a module? do we need an instance? can we just call a setup method or something?
       def initialize
         # no-op without OpenTelemetry API & config
-        return unless defined?(OpenTelemetry) && NewRelic::Agent.config[:'feature_flag.opentelemetry_bridge']
+        return unless defined?(OpenTelemetry) &&
+          NewRelic::Agent.config[:'feature_flag.opentelemetry_bridge']
 
         OpenTelemetryHandler.install_bridge
       end
@@ -19,7 +19,6 @@ def self.install_bridge
         require 'opentelemetry' # requires the opentelemetry-api gem
         require_relative 'opentelemetry/trace'
 
-        # TODO: Turn off New Relic instrumentation
         ::OpenTelemetry.tracer_provider = NewRelic::Agent::OpenTelemetry::Trace::TracerProvider.new
       end
     end

lib/new_relic/agent/transaction.rb

@@ -951,11 +951,6 @@ def ignore_trace?
         @ignore_trace
       end
 
-      # TODO: THIS IS FOR OTEL AND SHOULD NOT STAY HEERE
-      def set_attribute(key, value)
-        current_segment&.set_attribute(key, value)
-      end
-
       private
 
       def process_cpu

lib/new_relic/agent/transaction/segment.rb

@@ -46,12 +46,6 @@ def add_custom_attributes(p)
           attributes.merge_custom_attributes(p)
         end
 
-        # TODO: THIS IS AN OTEL OVERRIDE
-        # IT SHOULD NOT LIVE HERE
-        def set_attribute(key, value)
-          add_custom_attributes({key => value})
-        end
-
         def self.finish(segment)
           return unless segment
 

test/multiverse/suites/hybrid_agent/README.md

@@ -49,6 +49,7 @@ Example:
 def focus_tests
   %w[does_not_create_segment_without_a_transaction]
 end
+```
 
 ```output
 $ bermq hybrid_agent

test/multiverse/suites/hybrid_agent/hybrid_agent_test.rb

@@ -27,10 +27,11 @@ def teardown
   # It looks for the snake cased version of the testDescription field in the JSON
   # Ex: %w[does_not_create_segment_without_a_transaction] would only run
   # `"testDescription": "Does not create segment without a transaction"`
-  # Using this to add tests individually until the full suite can be run on the CI
+  #
+  # Now that we're starting to implement, use this to add tests individually
+  # until the full suite can be run on the CI
   def focus_tests
     %w[creates_opentelemetry_segment_in_a_transaction]
-    # []
   end
 
   test_cases = load_cross_agent_test('hybrid_agent')