Skip to content

Commit 4d7f489

Browse files
committed
update tests for major version todos
1 parent 359ce58 commit 4d7f489

File tree

2 files changed

+0
-32
lines changed

2 files changed

+0
-32
lines changed

test/new_relic/agent/pipe_channel_manager_test.rb

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@ def test_listener_merges_transaction_traces
7979
end
8080

8181
def test_listener_merges_error_traces
82-
skip_for_ruby_2_5_9_and_rails_6_x
83-
8482
sampler = NewRelic::Agent.agent.error_collector
8583
sampler.notice_error(Exception.new('message'), :uri => '/myurl/',
8684
:metric => 'path', :referer => 'test_referer',
@@ -132,8 +130,6 @@ def test_listener_merges_analytics_events
132130
end
133131

134132
def test_listener_merges_error_events
135-
skip_for_ruby_2_5_9_and_rails_6_x
136-
137133
error_event_aggregator = NewRelic::Agent.agent.error_collector.error_event_aggregator
138134
reset_lifetime_counts!(error_event_aggregator)
139135

@@ -364,12 +360,4 @@ def reset_lifetime_counts!(container)
364360
buffer.instance_variable_set(:@captured_lifetime, 0)
365361
buffer.instance_variable_set(:@seen_lifetime, 0)
366362
end
367-
368-
def skip_for_ruby_2_5_9_and_rails_6_x
369-
# TODO: MAJOR VERSION - remove this method and its calls when Ruby 2.5 is no longer supported
370-
skip if RUBY_VERSION == '2.5.9' &&
371-
defined?(Rails::VERSION::STRING) &&
372-
# version string starts with 6.0 or 6.1
373-
Rails::VERSION::STRING =~ /\A6\.(0|1)/
374-
end
375363
end

test/new_relic/dependency_detection_test.rb

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -171,26 +171,6 @@ def test_config_disabling_with_enabled
171171
end
172172
end
173173

174-
# TODO: MAJOR VERSION - Deprecated!
175-
def test_config_disabling_with_disable_testing
176-
executed = false
177-
178-
dd = DependencyDetection.defer do
179-
named(:testing)
180-
executes { executed = true }
181-
end
182-
183-
with_config(:disable_testing => true) do
184-
executed = false
185-
DependencyDetection.detect!
186-
187-
refute_predicate dd, :disabled_configured?
188-
assert_predicate dd, :deprecated_disabled_configured?
189-
refute_predicate dd, :allowed_by_config?
190-
refute executed
191-
end
192-
end
193-
194174
def test_config_enabling_with_enabled
195175
executed = false
196176

0 commit comments

Comments
 (0)