Skip to content

Commit abe53d4

Browse files
authored
Merge pull request #3400 from newrelic/otel_bridge_no_metrics_for_now
Fix warnings for Otel bridge record_metric
2 parents ad02c9d + b87f8d7 commit abe53d4

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

lib/new_relic/agent/opentelemetry_bridge.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ def initialize
1111
if defined?(OpenTelemetry) && Agent.config[:'opentelemetry.enabled'] && Agent.config[:'opentelemetry.traces.enabled']
1212
OpenTelemetryBridge.install
1313
NewRelic::Agent.record_metric('Supportability/Tracing/Ruby/OpenTelemetryBridge/enabled', 0.0)
14-
else
15-
NewRelic::Agent.record_metric('Supportability/Tracing/Ruby/OpenTelemetryBridge/disabled', 0.0)
14+
# else
15+
# This record metric calls happen before the agent is fully started, which causes us to log warnings every single time the agent runs.
16+
# NewRelic::Agent.record_metric('Supportability/Tracing/Ruby/OpenTelemetryBridge/disabled', 0.0)
1617
end
1718
end
1819

test/new_relic/agent/opentelemetry_bridge_test.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,13 @@ def test_adds_supportability_metric_when_opentelemetry_enabled
6868
end
6969
end
7070

71-
def test_adds_supportability_metric_when_opentelemetry_disabled
72-
with_config(:'opentelemetry.enabled' => false) do
73-
NewRelic::Agent::OpenTelemetryBridge.new
71+
# def test_adds_supportability_metric_when_opentelemetry_disabled
72+
# with_config(:'opentelemetry.enabled' => false) do
73+
# NewRelic::Agent::OpenTelemetryBridge.new
7474

75-
assert_metrics_recorded('Supportability/Tracing/Ruby/OpenTelemetryBridge/disabled')
76-
end
77-
end
75+
# assert_metrics_recorded('Supportability/Tracing/Ruby/OpenTelemetryBridge/disabled')
76+
# end
77+
# end
7878
end
7979
end
8080
end

0 commit comments

Comments
 (0)