removed other api methods

Author: tannalynn

CHANGELOG.md

@@ -8,7 +8,7 @@
 
 - **Breaking Change: Removal of Cross Application Tracing (CAT)**
 
-  Previously, Cross Application Tracing (CAT) was deprecated in favor of Distributed Tracing. CAT functionality has now been removed. The configuration option `cross_application_tracer.enabled` has been removed. Public API methods `NewRelic::Agent::External.process_request_metadata` and `NewRelic::Agent::External.get_response_metadata` have also been removed. [PR#3333](https://github.com/newrelic/newrelic-ruby-agent/pull/3333)
+  Previously, Cross Application Tracing (CAT) was deprecated in favor of Distributed Tracing. CAT functionality has now been removed. The configuration option `cross_application_tracer.enabled` has been removed. Public API methods `NewRelic::Agent::External.process_request_metadata`, `NewRelic::Agent::External.get_response_metadata`, `NewRelic::Agent::Transaction::ExternalRequestSegment#process_response_metadata`, and `NewRelic::Agent::Transaction::ExternalRequestSegment#get_request_metadata` have also been removed. [PR#3333](https://github.com/newrelic/newrelic-ruby-agent/pull/3333)
 
 - **Feature: Add `logger` as a dependency**
   The `logger` gem is now listed as a dependency of the agent to ensure continued logging functionality and support for Ruby 4.0.0 and newer versions. [PR#3293](https://github.com/newrelic/newrelic-ruby-agent/pull/3293)

lib/new_relic/agent/transaction/external_request_segment.rb

@@ -106,77 +106,6 @@ def cross_process_transaction_name # :nodoc:
           @app_data && @app_data[1]
         end
 
-        # Obtain an obfuscated +String+ suitable for delivery across public networks that identifies this application
-        # and transaction to another application which is also running a New Relic agent. This +String+ can be processed
-        # by +process_request_metadata+ on the receiving application.
-        #
-        # @return [String] obfuscated request metadata to send
-        #
-        # @api public
-        #
-        def get_request_metadata
-          NewRelic::Agent.record_api_supportability_metric(:get_request_metadata)
-          return unless CrossAppTracing.cross_app_enabled?
-
-          if transaction
-
-            # build hash of CAT metadata
-            #
-            rmd = {
-              NewRelicID: NewRelic::Agent.config[:cross_process_id],
-              NewRelicTransaction: [
-                transaction.guid,
-                false,
-                transaction.distributed_tracer.cat_trip_id,
-                transaction.distributed_tracer.cat_path_hash
-              ]
-            }
-
-            # flag cross app in the state so transaction knows to add bits to payload
-            #
-            transaction.distributed_tracer.is_cross_app_caller = true
-
-            # add Synthetics header if we have it
-            #
-            rmd[:NewRelicSynthetics] = transaction.raw_synthetics_header if transaction.raw_synthetics_header
-
-            # obfuscate the generated request metadata JSON
-            #
-            obfuscator.obfuscate(::JSON.dump(rmd))
-
-          end
-        rescue => e
-          NewRelic::Agent.logger.error('error during get_request_metadata', e)
-        end
-
-        # Process obfuscated +String+ sent from a called application that is also running a New Relic agent and
-        # save information in current transaction for inclusion in a trace. This +String+ is generated by
-        # +get_response_metadata+ on the receiving application.
-        #
-        # @param response_metadata [String] received obfuscated response metadata
-        #
-        # @api public
-        #
-        def process_response_metadata(response_metadata)
-          NewRelic::Agent.record_api_supportability_metric(:process_response_metadata)
-          if transaction
-            app_data = ::JSON.parse(obfuscator.deobfuscate(response_metadata))[APP_DATA_KEY]
-
-            # validate cross app id
-            #
-            if Array === app_data and CrossAppTracing.trusted_valid_cross_app_id?(app_data[0])
-              @app_data = app_data
-              update_segment_name
-            else
-              NewRelic::Agent.logger.error('error processing response metadata: invalid/non-trusted ID')
-            end
-          end
-
-          nil
-        rescue => e
-          NewRelic::Agent.logger.error('error during process_response_metadata', e)
-        end
-
         def record_metrics
           add_unscoped_metrics
           super

lib/new_relic/supportability_helper.rb

@@ -23,7 +23,6 @@ module SupportabilityHelper
       :disable_all_tracing,
       :disable_sql_recording,
       :drop_buffered_data,
-      :get_response_metadata,
       :get_transaction_name,
       :ignore_apdex,
       :ignore_enduser,
@@ -38,7 +37,6 @@ module SupportabilityHelper
       :notice_sql,
       :notice_statement,
       :perform_action_with_newrelic_trace,
-      :process_response_metadata,
       :record_custom_event,
       :record_metric,
       :record_llm_feedback_event,

test/new_relic/agent/transaction/external_request_segment_test.rb

@@ -452,122 +452,6 @@ def test_uri_recorded_as_tt_attribute
         assert_equal uri, node.params[:uri]
       end
 
-      # --- get_request_metadata
-
-      def test_get_request_metadata_with_cross_app_tracing_disabled
-        with_config(cat_config.merge(:'cross_application_tracer.enabled' => false)) do
-          in_transaction do |txn|
-            rmd = external_request_segment { |s| s.get_request_metadata }
-
-            refute rmd, '`get_request_metadata` should return nil with cross app tracing disabled'
-          end
-        end
-      end
-
-      def test_get_request_metadata_not_in_transaction
-        with_config(cat_config) do
-          refute external_request_segment { |s| s.get_request_metadata }
-        end
-      end
-
-      # --- process_response_metadata
-
-      def test_process_response_metadata
-        with_config(cat_config) do
-          in_transaction do |txn|
-            rmd = @obfuscator.obfuscate(::JSON.dump({
-              NewRelicAppData: [
-                NewRelic::Agent.config[:cross_process_id],
-                'Controller/root/index',
-                0.001,
-                0.5,
-                60,
-                txn.guid
-              ]
-            }))
-
-            segment = external_request_segment { |s| s.process_response_metadata(rmd); s }
-
-            assert_equal 'ExternalTransaction/example.com/269975#22824/Controller/root/index', segment.name
-          end
-        end
-      end
-
-      def test_process_response_metadata_not_in_transaction
-        with_config(cat_config) do
-          rmd = @obfuscator.obfuscate(::JSON.dump({
-            NewRelicAppData: [
-              NewRelic::Agent.config[:cross_process_id],
-              'Controller/root/index',
-              0.001,
-              0.5,
-              60,
-              'abcdef'
-            ]
-          }))
-
-          segment = external_request_segment { |s| s.process_response_metadata(rmd); s }
-
-          assert_equal 'External/example.com/foo/get', segment.name
-        end
-      end
-
-      def test_process_response_metadata_with_invalid_cross_app_id
-        with_config(cat_config) do
-          in_transaction do |txn|
-            rmd = @obfuscator.obfuscate(::JSON.dump({
-              NewRelicAppData: [
-                'bugz',
-                'Controller/root/index',
-                0.001,
-                0.5,
-                60,
-                txn.guid
-              ]
-            }))
-
-            segment = nil
-            l = with_array_logger do
-              segment = external_request_segment { |s| s.process_response_metadata(rmd); s }
-            end
-
-            refute_empty l.array, 'process_response_metadata should log error on invalid ID'
-            assert_includes l.array.first, 'invalid/non-trusted ID'
-
-            assert_equal 'External/example.com/foo/get', segment.name
-          end
-        end
-      end
-
-      def test_process_response_metadata_with_untrusted_cross_app_id
-        with_config(cat_config) do
-          in_transaction do |txn|
-            rmd = @obfuscator.obfuscate(::JSON.dump({
-              NewRelicAppData: [
-                '190#666',
-                'Controller/root/index',
-                0.001,
-                0.5,
-                60,
-                txn.guid
-              ]
-            }))
-
-            segment = nil
-            l = with_array_logger do
-              segment = external_request_segment { |s| s.process_response_metadata(rmd); s }
-            end
-
-            refute_empty l.array, 'process_response_metadata should log error on invalid ID'
-            assert_includes l.array.first, 'invalid/non-trusted ID'
-
-            assert_equal 'External/example.com/foo/get', segment.name
-          end
-        end
-      end
-
-      # ---
-
       def test_segment_adds_distributed_trace_header
         distributed_tracing_config = {
           :'distributed_tracing.enabled' => true,