Skip to content

Refactor log_event_aggregator.rb #3440

@hannahramadan

Description

@hannahramadan

Logger was the only logging instrumentation in the agent for awhile. Now that we have Logstasher and Logging, we should refactor the LogEventAggregator class to more cleanly support these three instrumentations.

Example of duplication:

  LOGGER_SUPPORTABILITY_FORMAT = 'Supportability/Logging/Ruby/Logger/%s'.freeze
  LOGSTASHER_SUPPORTABILITY_FORMAT = 'Supportability/Logging/Ruby/LogStasher/%s'.freeze
  LOGGING_SUPPORTABILITY_FORMAT = 'Supportability/Logging/Ruby/Logging/%s'.freeze

comments:
https://github.com/newrelic/newrelic-ruby-agent/pull/3420/changes#r2775307300
https://github.com/newrelic/newrelic-ruby-agent/pull/3420/changes#r2775315348

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions