test: Removed t.diagnostic from tests (#2858)

Author: bizob2828

test/integration/distributed-tracing/trace-context-cross-agent.test.js

@@ -326,14 +326,6 @@ async function runTestCase(testCase, parentTest) {
   })
 
   await parentTest.test('trace context: ' + testCase.test_name, (t, end) => {
-    if (testCase.comment && testCase.comment.length > 0) {
-      const comment = Array.isArray(testCase.comment)
-        ? testCase.comment.join('\n')
-        : testCase.comment
-
-      t.diagnostic(comment)
-    }
-
     const agent = helper.instrumentMockedAgent({})
     agent.recordSupportability = recordSupportability
     agent.config.trusted_account_key = testCase.trusted_account_key

test/integration/uninstrumented/package.json

@@ -24,5 +24,8 @@
     "restify": "*",
     "superagent": "*",
     "when": "*"
+  },
+  "engines": {
+    "node": ">=18"
   }
 }

test/integration/uninstrumented/uninstrumented.test.js

@@ -60,7 +60,7 @@ test('all instrumented modules should be detected when uninstrumented', (t, end)
         require(module)
         loaded.push(module)
       } catch {
-        t.diagnostic('failed to load ' + module)
+        // silently fail
       }
     }
   })

test/lib/temp-override-uncaught.js

@@ -34,9 +34,7 @@ const oldListeners = {
  */
 function tempOverrideUncaught({ t, handler, type = EXCEPTION }) {
   if (!handler) {
-    handler = function uncaughtTestHandler() {
-      t.diagnostic('uncaught handler not defined')
-    }
+    handler = function uncaughtTestHandler() {}
   }
 
   oldListeners[type] = process.listeners(type)

test/lib/temp-remove-listeners.js

@@ -19,7 +19,6 @@
  */
 module.exports = function tempRemoveListeners({ t, emitter, event }) {
   if (!emitter) {
-    t.diagnostic(`Not removing ${event} listeners, emitter does not exist`)
     return
   }
 

test/unit/collector/facts.test.js

@@ -730,7 +730,6 @@ test('display_host facts', async (t) => {
   await t.test('should be ipv6 when ipv_preference === 6', (t, end) => {
     const { agent, facts } = t.nr
     if (!agent.config.getIPAddresses().ipv6) {
-      t.diagnostic('this machine does not have an ipv6 address, skipping')
       end()
     }
 
@@ -753,7 +752,6 @@ test('display_host facts', async (t) => {
   await t.test('returns no ipv4, hostname should be ipv6 if possible', (t, end) => {
     const { agent, facts } = t.nr
     if (!agent.config.getIPAddresses().ipv6) {
-      t.diagnostic('this machine does not have an ipv6 address, skipping')
       end()
     }