feat!: Dropped support for Node.js 18 (#3097)

Author: svetlanabrennan

.github/workflows/benchmark-tests.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
     - uses: actions/checkout@v4

.github/workflows/ci-workflow.yml

@@ -103,7 +103,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -135,7 +135,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -171,7 +171,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -222,7 +222,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -245,7 +245,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/smoke-test-workflow.yml

@@ -24,7 +24,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
     - uses: actions/checkout@v4

.github/workflows/versioned-security-agent.yml

@@ -66,7 +66,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
     - uses: actions/checkout@v4

THIRD_PARTY_NOTICES.md

@@ -82,7 +82,7 @@ code, the source code can be found at [https://github.com/newrelic/node-newrelic
 
 **[optionalDependencies](#optionalDependencies)**
 
-* [@contrast/fn-inspect](#contrastfn-inspect)
+* [@newrelic/fn-inspect](#newrelicfn-inspect)
 * [@newrelic/native-metrics](#newrelicnative-metrics)
 * [@prisma/prisma-fmt-wasm](#prismaprisma-fmt-wasm)
 
@@ -95,7 +95,7 @@ code, the source code can be found at [https://github.com/newrelic/node-newrelic
 
 ### @grpc/grpc-js
 
-This product includes source derived from [@grpc/grpc-js](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js) ([v1.13.4](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/tree/v1.13.4)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/blob/v1.13.4/LICENSE):
+This product includes source derived from [@grpc/grpc-js](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js) ([v1.13.3](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/tree/v1.13.3)), distributed under the [Apache-2.0 License](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js/blob/v1.13.3/LICENSE):
 
 ```
                                  Apache License
@@ -1902,7 +1902,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 ### import-in-the-middle
 
-This product includes source derived from [import-in-the-middle](https://github.com/nodejs/import-in-the-middle) ([v1.14.0](https://github.com/nodejs/import-in-the-middle/tree/v1.14.0)), distributed under the [Apache-2.0 License](https://github.com/nodejs/import-in-the-middle/blob/v1.14.0/LICENSE):
+This product includes source derived from [import-in-the-middle](https://github.com/nodejs/import-in-the-middle) ([v1.13.2](https://github.com/nodejs/import-in-the-middle/tree/v1.13.2)), distributed under the [Apache-2.0 License](https://github.com/nodejs/import-in-the-middle/blob/v1.13.2/LICENSE):
 
 ```
                                  Apache License
@@ -2333,7 +2333,7 @@ SOFTWARE.
 
 ### @aws-sdk/client-s3
 
-This product includes source derived from [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3) ([v3.821.0](https://github.com/aws/aws-sdk-js-v3/tree/v3.821.0)), distributed under the [Apache-2.0 License](https://github.com/aws/aws-sdk-js-v3/blob/v3.821.0/LICENSE):
+This product includes source derived from [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3) ([v3.808.0](https://github.com/aws/aws-sdk-js-v3/tree/v3.808.0)), distributed under the [Apache-2.0 License](https://github.com/aws/aws-sdk-js-v3/blob/v3.808.0/LICENSE):
 
 ```
                                 Apache License
@@ -2542,7 +2542,7 @@ This product includes source derived from [@aws-sdk/client-s3](https://github.co
 
 ### @aws-sdk/s3-request-presigner
 
-This product includes source derived from [@aws-sdk/s3-request-presigner](https://github.com/aws/aws-sdk-js-v3) ([v3.821.0](https://github.com/aws/aws-sdk-js-v3/tree/v3.821.0)), distributed under the [Apache-2.0 License](https://github.com/aws/aws-sdk-js-v3/blob/v3.821.0/LICENSE):
+This product includes source derived from [@aws-sdk/s3-request-presigner](https://github.com/aws/aws-sdk-js-v3) ([v3.808.0](https://github.com/aws/aws-sdk-js-v3/tree/v3.808.0)), distributed under the [Apache-2.0 License](https://github.com/aws/aws-sdk-js-v3/blob/v3.808.0/LICENSE):
 
 ```
                                 Apache License
@@ -4370,7 +4370,7 @@ SOFTWARE.
 
 ### eslint-plugin-jsdoc
 
-This product includes source derived from [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) ([v50.7.1](https://github.com/gajus/eslint-plugin-jsdoc/tree/v50.7.1)), distributed under the [BSD-3-Clause License](https://github.com/gajus/eslint-plugin-jsdoc/blob/v50.7.1/LICENSE):
+This product includes source derived from [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) ([v50.6.14](https://github.com/gajus/eslint-plugin-jsdoc/tree/v50.6.14)), distributed under the [BSD-3-Clause License](https://github.com/gajus/eslint-plugin-jsdoc/blob/v50.6.14/LICENSE):
 
 ```
 Copyright (c) 2018, Gajus Kuizinas (http://gajus.com/)
@@ -4402,7 +4402,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 ### eslint
 
-This product includes source derived from [eslint](https://github.com/eslint/eslint) ([v9.28.0](https://github.com/eslint/eslint/tree/v9.28.0)), distributed under the [MIT License](https://github.com/eslint/eslint/blob/v9.28.0/LICENSE):
+This product includes source derived from [eslint](https://github.com/eslint/eslint) ([v9.26.0](https://github.com/eslint/eslint/tree/v9.26.0)), distributed under the [MIT License](https://github.com/eslint/eslint/blob/v9.26.0/LICENSE):
 
 ```
 Copyright OpenJS Foundation and other contributors, <www.openjsf.org>
@@ -5235,9 +5235,9 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 ## optionalDependencies
 
-### @contrast/fn-inspect
+### @newrelic/fn-inspect
 
-This product includes source derived from [@contrast/fn-inspect](https://github.com/Contrast-Security-Inc/node-fn-inspect) ([v4.3.0](https://github.com/Contrast-Security-Inc/node-fn-inspect/tree/v4.3.0)), distributed under the [MIT License](https://github.com/Contrast-Security-Inc/node-fn-inspect/blob/v4.3.0/LICENSE):
+This product includes source derived from [@newrelic/fn-inspect](https://github.com/newrelic-forks/node-fn-inspect) ([v4.4.0](https://github.com/newrelic-forks/node-fn-inspect/tree/v4.4.0)), distributed under the [MIT License](https://github.com/newrelic-forks/node-fn-inspect/blob/v4.4.0/LICENSE):
 
 ```
 Copyright 2022 Contrast Security, Inc

lib/environment.js

@@ -12,7 +12,6 @@ const logger = require('./logger').child({ component: 'environment' })
 const stringify = require('json-stringify-safe')
 const asyncEachLimit = require('./util/async-each-limit')
 const DISPATCHER_VERSION = 'Dispatcher Version'
-const semver = require('semver')
 
 // As of 1.7.0 you can no longer dynamically link v8
 // https://github.com/nodejs/io.js/commit/d726a177ed
@@ -293,19 +292,17 @@ function remapConfigSettings() {
       }
     })
 
-    maybeAddMissingProcessVars()
+    addMissingProcessVars()
   }
 }
 
 /**
  * As of Node 19 DTrace and ETW are no longer bundled
  * see: https://nodejs.org/en/blog/announcements/v19-release-announce#dtrace/systemtap/etw-support
  */
-function maybeAddMissingProcessVars() {
-  if (semver.gte(process.version, '19.0.0')) {
-    addSetting(remapping.node_use_dtrace, 'no')
-    addSetting(remapping.node_use_etw, 'no')
-  }
+function addMissingProcessVars() {
+  addSetting(remapping.node_use_dtrace, 'no')
+  addSetting(remapping.node_use_etw, 'no')
 }
 
 async function getOtherPackages() {

package.json

@@ -151,7 +151,7 @@
   ],
   "homepage": "https://github.com/newrelic/node-newrelic",
   "engines": {
-    "node": ">=18",
+    "node": ">=20",
     "npm": ">=6.0.0"
   },
   "directories": {
@@ -224,7 +224,7 @@
   },
   "optionalDependencies": {
     "@newrelic/fn-inspect": "^4.4.0",
-    "@newrelic/native-metrics": "^11.1.0",
+    "@newrelic/native-metrics": "^12.0.0",
     "@prisma/prisma-fmt-wasm": "^4.17.0-16.27eb2449f178cd9fe1a4b892d732cc4795f75085"
   },
   "devDependencies": {
@@ -234,7 +234,7 @@
     "@matteo.collina/tspl": "^0.1.1",
     "@newrelic/eslint-config": "^0.5.0",
     "@newrelic/newrelic-oss-cli": "^0.1.2",
-    "@newrelic/test-utilities": "^9.1.0",
+    "@newrelic/test-utilities": "^10.0.0",
     "@octokit/rest": "^18.0.15",
     "@slack/bolt": "^3.7.0",
     "@smithy/eventstream-codec": "^2.2.0",

test/integration/uninstrumented/package.json

@@ -26,6 +26,6 @@
     "when": "*"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=20"
   }
 }

test/unit/environment.test.js

@@ -15,7 +15,6 @@ const { spawn } = require('node:child_process')
 // environment when testing.
 delete process.env.NODE_ENV
 
-const { isSupportedVersion } = require('../lib/agent_helper')
 const environment = require('../../lib/environment')
 
 function find(settings, name) {
@@ -128,67 +127,6 @@ test('with process.config', (t) => {
   )
 })
 
-// TODO: remove tests when we drop support for node 18
-test('without process.config', { skip: isSupportedVersion('v19.0.0') }, async (t) => {
-  t.beforeEach(async (ctx) => {
-    ctx.nr.conf = { ...process.config }
-
-    /**
-     * TODO: Augmenting process.config has been deprecated in Node 16.
-     * When fully disabled we may no-longer be able to test but also may no-longer need to.
-     * https://nodejs.org/api/deprecations.html#DEP0150
-     */
-    process.config = null
-
-    ctx.nr.settings = await environment.getJSON()
-  })
-
-  t.afterEach(async (ctx) => {
-    process.config = { ...ctx.nr.conf }
-    ctx.nr.settings = await environment.getJSON()
-  })
-
-  await t.test('assertions without process.config', (t) => {
-    const { settings } = t.nr
-    assert.equal(
-      find(settings, 'npm installed?'),
-      undefined,
-      'should not know whether npm was installed with Node.js'
-    )
-    assert.equal(
-      find(settings, 'WAF build system installed?'),
-      undefined,
-      'should not know whether WAF was installed with Node.js'
-    )
-    assert.equal(
-      find(settings, 'OpenSSL support?'),
-      undefined,
-      'should not know whether OpenSSL support was compiled into Node.js'
-    )
-    assert.equal(
-      find(settings, 'Dynamically linked to OpenSSL?'),
-      undefined,
-      'Dynamically linked to OpenSSL?'
-    )
-    assert.equal(
-      find(settings, 'Dynamically linked to V8?'),
-      undefined,
-      'Dynamically linked to V8?'
-    )
-    assert.equal(
-      find(settings, 'Dynamically linked to Zlib?'),
-      undefined,
-      'Dynamically linked to Zlib?'
-    )
-    assert.equal(find(settings, 'DTrace support?'), undefined, 'DTrace support?')
-    assert.equal(
-      find(settings, 'Event Tracing for Windows (ETW) support?'),
-      undefined,
-      'Event Tracing for Windows (ETW) support?'
-    )
-  })
-})
-
 test('should have built a flattened package list', (t) => {
   const { settings } = t.nr
   const packages = find(settings, 'Packages')
@@ -222,19 +160,6 @@ test('should get correct version for dependencies', async () => {
   })
 })
 
-// TODO: remove this test when we drop support for node 18
-test(
-  'should resolve refresh where deps and deps of deps are symlinked to each other',
-  { skip: isSupportedVersion('v19.0.0') },
-  async () => {
-    process.config.variables.node_prefix = path.join(__dirname, '../lib/example-deps')
-    const data = await environment.getJSON()
-    const pkgs = find(data, 'Dependencies')
-    const customPkgs = pkgs.filter((pkg) => pkg.includes('custom-pkg'))
-    assert.equal(customPkgs.length, 3)
-  }
-)
-
 test('should not crash when given a file in NODE_PATH', (t, end) => {
   const env = {
     NODE_PATH: path.join(__dirname, 'environment.test.js'),

test/unit/util/hashes.test.js

@@ -11,8 +11,6 @@ const test = require('node:test')
 const testData = require('../../lib/obfuscation-data')
 const hashes = require('../../../lib/util/hashes')
 
-const major = process.version.slice(1).split('.').map(Number).shift()
-
 test('#makeId always returns the correct length', () => {
   for (let length = 4; length < 64; length++) {
     for (let attempts = 0; attempts < 500; attempts++) {
@@ -53,19 +51,3 @@ test('deobfuscation', async (t) => {
     }
   })
 })
-
-// TODO: remove this test when we drop support for node 18
-test('getHash', { skip: major > 18 }, async (t) => {
-  /**
-   * TODO: crypto.DEFAULT_ENCODING has been deprecated.
-   * When fully disabled, this test can likely be removed.
-   * https://nodejs.org/api/deprecations.html#DEP0091
-   */
-  await t.test('should not crash when changing the DEFAULT_ENCODING key on crypto', () => {
-    const crypto = require('node:crypto')
-    const oldEncoding = crypto.DEFAULT_ENCODING
-    crypto.DEFAULT_ENCODING = 'utf-8'
-    assert.doesNotThrow(hashes.getHash.bind(null, 'TEST_APP', 'TEST_TXN'))
-    crypto.DEFAULT_ENCODING = oldEncoding
-  })
-})