fix: Updated message consumer subscribers to properly time the consumption actions (#3660)

Author: bizob2828

lib/subscribers/message-consumer.js

@@ -105,7 +105,7 @@ class MessageConsumerSubscriber extends Subscriber {
    */
   asyncStart() {
     const ctx = this.agent.tracer.getContext()
-    const tx = ctx?.transaction
+    const tx = ctx.transaction
     tx.setPartialName(this.name)
     // Note: this is not using `Subscriber.createSegment`
     // this is because it enters the segment and returns a new ctx
@@ -117,6 +117,7 @@ class MessageConsumerSubscriber extends Subscriber {
       parent: tx.trace.root,
       transaction: tx
     })
+    tx.baseSegment.start()
 
     this.addConsumeParameters(tx)
 

test/versioned/amqplib/callback.test.js

@@ -480,6 +480,8 @@ test('amqplib callback instrumentation', async function (t) {
     agent.on('transactionFinished', function (tx) {
       amqpUtils.verifyConsumeTransaction(tx, exchange, queue, 'consume-tx-key')
       assert.ok(tx.trace.getDurationInMillis() >= PROMISE_WAIT, 'transaction should account for async work')
+
+      assert.ok(tx.baseSegment.getDurationInMillis() >= PROMISE_WAIT, 'base segment should account for async work')
       end()
     })
 

test/versioned/amqplib/promises.test.js

@@ -457,6 +457,7 @@ test('amqplib promise instrumentation', async function (t) {
     process.nextTick(() => {
       amqpUtils.verifyConsumeTransaction(tx, amqpUtils.DIRECT_EXCHANGE, queue, 'consume-tx-key')
       assert.ok(tx.trace.getDurationInMillis() >= PROMISE_WAIT, 'transaction should account for async work')
+      assert.ok(tx.baseSegment.getDurationInMillis() >= PROMISE_WAIT, 'base segment should account for async work')
     })
   })