Skip to content

Commit 0c6cc4c

Browse files
authored
Merge pull request #14 from newrelic/fixDeltas
Fix rate and deltas
2 parents a3d9410 + 9299b0c commit 0c6cc4c

File tree

2 files changed

+35
-2
lines changed

2 files changed

+35
-2
lines changed

CHANGELOG.md

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,38 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/)
55
and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## 1.1.4 (2018-10-19)
8+
9+
### Bugs fixed
10+
11+
#### Allow rate and deltas
12+
13+
Metrics of type rate and delta cannot be added unless there is a namespacing attribute on the metric-set.
14+
15+
## 1.1.3 (2018-10-12)
16+
17+
### Changed:
18+
19+
#### Update to SDKv3
20+
21+
Updated the integration code from the previous version of the SDK to [SDK v3](https://github.com/newrelic/infra-integrations-sdk/#upgrading-from-sdk-v2-to-v3).
22+
23+
### Added:
24+
25+
#### Old password support
26+
27+
Previously when trying to run Mysql integration on a mysql-server with old password support https://dev.mysql.com/doc/refman/5.6/en/server-system-variables.html#sysvar_old_passwords integration won't run. If customer has set old_passwords=1 at the MySQL server integration can now connect to it.
28+
29+
#### Ignore bin folder
30+
31+
`bin` folder added to `.gitignore`.
32+
33+
### Bugs fixed
34+
35+
#### Hostname issue
36+
Integration CLI-arguments are no longer overridden by environment-variables
37+
As CLI-args are used by the NRI agent `HOSTNAME` that is a common bash env-var is not used to set MySql-host unless no hostname is provided via config.
38+
739
## 1.1.2 (2018-10-16)
840
### Added
941
- Included metric `Master_Host`

src/mysql.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@ import (
44
"fmt"
55

66
sdk_args "github.com/newrelic/infra-integrations-sdk/args"
7+
"github.com/newrelic/infra-integrations-sdk/data/metric"
78
"github.com/newrelic/infra-integrations-sdk/integration"
89
"github.com/newrelic/infra-integrations-sdk/log"
910
)
1011

1112
const (
1213
integrationName = "com.newrelic.mysql"
13-
integrationVersion = "1.1.0"
14+
integrationVersion = "1.1.3"
1415
)
1516

1617
type argumentList struct {
@@ -43,7 +44,7 @@ func main() {
4344
log.SetupLogging(args.Verbose)
4445

4546
e := i.LocalEntity()
46-
ms := e.NewMetricSet("MysqlSample")
47+
ms := e.NewMetricSet("MysqlSample", metric.Attr("hostname", args.Hostname))
4748

4849
db, err := openDB(generateDSN(args))
4950
fatalIfErr(err)

0 commit comments

Comments
 (0)