feat: chatbot slowness scenario, some local fixes (#18)

fix: reverting frontend APM frontend changes for now

adding PR template

adding PR template

fixing synthetic

pr template patch

Author: jgoddard19

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,64 @@
+🚀 Pull Request
+========================
+
+🎯 PR Type
+----------
+-   [ ] **Feature:** Adds new functionality or user-facing change.
+-   [ ] **Bug Fix:** Solves a defect or incorrect behavior.
+-   [ ] **Refactor:** Improves code structure/readability without changing external behavior.
+-   [ ] **Documentation:** Updates to README, Wiki, or internal docs.
+-   [ ] **Chore:** Non-code changes (e.g., CI configuration, dependency bumps).
+
+1\. Issue Tracking & Reference
+------------------------------
+-   **Ticket Number(s):** [e.g., JIRA-123, GH-456]
+-   **Ticket Link(s):** [Insert direct URL to the issue/ticket here]
+
+2\. Summary of Changes
+----------------------
+Briefly describe the purpose of this PR. What is the overall goal it achieves?
+-   **Expected Outcome:** [What should the user or system see after this PR is merged and deployed? (e.g., "New pricing page goes live," "Latency decreases by 100ms," "Bug X is resolved.")]
+
+### Detailed Change Log & Justification
+List each significant change made in this PR. For each, provide a brief justification explaining *why* the change was necessary (e.g., to fix a bug, meet a requirement, or improve performance).
+-   **Change 1:** [Description of the change, e.g., "Updated `UserController.js` to handle null user inputs."]
+    -   **Justification:** [e.g., "This prevents a server crash when a user submits an empty form."]
+-   **Change 2:** [Description of the change]
+    -   **Justification:** [Explanation of why this change was made]
+
+3\. Testing
+-----------
+Describe how you tested this PR. The quality of testing directly impacts the speed of review and deployment.
+
+### Testing Strategy
+-   **Environment Used:** (e.g., Local, Sandbox, Staging)
+-   **Production Safety Assessment:** [Why do you believe this change is safe to deploy to production? (e.g., "Covered by comprehensive unit and integration tests," "It's an idempotent, non-breaking change," "Only touches static asset files.")]
+-   **What areas were NOT tested and why?** (e.g., "Did not test old IE browsers as they are deprecated.")
+
+### Coverage Details
+
+| Scenario      | Details                                                                    | Results                           |
+| ------------- | -------------------------------------------------------------------------- | --------------------------------- |
+| Happy Path    | [List sequential steps for the primary intended use case.]                 | [Add notes on outcome of testing] |
+| Edge Case 1   | [Test boundaries: null values, zero, max limits, concurrent actions, etc.] | [Add notes on outcome of testing] |
+| Edge Case ... | [Test boundaries: null values, zero, max limits, concurrent actions, etc.] | [Add notes on outcome of testing] |
+
+4\. Evidence
+------------
+Provide evidence of successful testing.
+-   **Screenshots/Gifs:** [Paste image links or attach screenshots here]
+-   **Console/Log Output Snippets:** [Paste relevant logs or links to log files]
+-   **Test Report Links:** [Link to test runs, etc.]
+
+_Testing and evidence are **REQUIRED** before requesting review!_
+
+5\. Review and Merge Checklist
+------------------------------
+Confirm the following prerequisites have been met by checking the boxes:
+-   [ ] All blocking review comments from the latest round are **resolved**.
+-   [ ] This branch has been rebased against the `main` branch and all **merge conflicts are resolved**.
+-   [ ] The code includes sufficient comments, particularly in complex or non-obvious areas.
+-   [ ] The code adheres to project **coding standards** (linting, style guides, best practices).
+-   [ ] Relevant documentation and runbooks have been updated, if necessary.
+-   [ ] My changes generate no new warnings or errors.
+-   [ ] My commits are squashed into a single, descriptive commit.

chatbot_service/chatbot_service.py

@@ -1,6 +1,7 @@
 import os
 import logging
 import json
+import ssl
 from contextlib import asynccontextmanager
 from typing import Optional
 from typing import Any
@@ -52,7 +53,17 @@ class HealthResponse(BaseModel):
 
 # https://mcp.deepwiki.com/sse
 
-mcp_client = Client(server_config)
+# Create SSL context that doesn't verify certificates (for self-signed certs)
+ssl_context = ssl.create_default_context()
+ssl_context.check_hostname = False
+ssl_context.verify_mode = ssl.CERT_NONE
+
+try:
+    mcp_client = Client(server_config, ssl_context=ssl_context)
+except TypeError:
+    # If Client doesn't accept ssl_context parameter, try without it
+    logger.warning("Client does not support ssl_context parameter, proceeding without SSL verification override")
+    mcp_client = Client(server_config)
 
 async def get_tools() -> list[Tool]:
     """

frontend_service/app/routes/support.tsx

@@ -32,10 +32,45 @@ export default function SupportPage() {
 
   useEffect(scrollToBottom, [messages, isBotTyping]);
 
+  // Demo scenario: Blocking synchronous Fibonacci calculation
+  const calculateFibonacci = (n: number): number => {
+    if (n <= 1) return n;
+    return calculateFibonacci(n - 1) + calculateFibonacci(n - 2);
+  };
+
   const handleSend = async () => {
     if (!inputMessage.trim()) return;
 
     const userMessageText = inputMessage.trim();
+
+    // Demo scenario
+    // Check for spending analysis triggers
+    // This will match variations like:
+    // - "analyze my spending"
+    // - "Analyze my spending."
+    // - "analyse my spending"
+    // - "spending analysis"
+    // - "check my spending"
+    const spendingAnalysisTriggers = [
+      /analyz[e]?\s+my\s+spending/i,
+      /analys[e]?\s+spending/i,
+      /spending\s+analys[ie]s/i,
+      /check\s+my\s+spending/i
+    ];
+
+    const isSpendingAnalysis = spendingAnalysisTriggers.some(
+      pattern => pattern.test(userMessageText)
+    );
+
+    if (isSpendingAnalysis) {
+      // Demo scenario: Simulates heavy computation on main thread
+      // This blocks the UI from updating before the user sees their message
+      console.warn('[DEMO] Running blocking Fibonacci calculation for spending analysis...');
+      const startTime = performance.now();
+      const result = calculateFibonacci(42); // ~3-5 seconds on average CPU
+      const endTime = performance.now();
+      console.warn(`[DEMO] Blocking calculation complete: fib(42) = ${result}, took ${(endTime - startTime).toFixed(0)}ms`);
+    }
     const newUserMessage: ChatMessage = {
       id: Date.now(),
       text: userMessageText,
@@ -44,7 +79,7 @@ export default function SupportPage() {
     };
 
     // 1. Add user message and clear input
-    setMessages((prev) => [...prev, newUserMessage]);
+    setMessages((prev: ChatMessage[]) => [...prev, newUserMessage]);
     setInputMessage('');
     setIsBotTyping(true);
 
@@ -75,23 +110,23 @@ export default function SupportPage() {
         timestamp: new Date().toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' }),
       };
 
-      setMessages((prev) => [...prev, newBotMessage]);
+      setMessages((prev: ChatMessage[]) => [...prev, newBotMessage]);
 
-    } catch (error) {
+    } catch (error: unknown) {
       console.error("Chatbot API call failed:", error);
       const errorMessage: ChatMessage = {
         id: Date.now() + 1,
-        text: `Sorry, I couldn't connect to the support service. Please ensure the chatbot service is running. Error: ${error.message}`,
+        text: `Sorry, I couldn't connect to the support service. Please ensure the chatbot service is running. Error: ${error instanceof Error ? error.message : 'Unknown error'}`,
         sender: 'bot',
         timestamp: new Date().toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' }),
       };
-      setMessages((prev) => [...prev, errorMessage]);
+      setMessages((prev: ChatMessage[]) => [...prev, errorMessage]);
     } finally {
       setIsBotTyping(false);
     }
   };
 
-  const handleKeyPress = (e: React.KeyboardEvent) => {
+  const handleKeyPress = (e: any) => {
     if (e.key === 'Enter' && !e.shiftKey) {
       e.preventDefault();
       handleSend();
@@ -163,7 +198,7 @@ export default function SupportPage() {
             flexDirection: 'column'
           }}
         >
-          {messages.map((message) => (
+          {messages.map((message: ChatMessage) => (
             <MessageBubble key={message.id} message={message} />
           ))}
 
@@ -192,7 +227,7 @@ export default function SupportPage() {
             autoFocus 
             size="small"
             value={inputMessage}
-            onChange={(e) => setInputMessage(e.target.value)}
+            onChange={(e: any) => setInputMessage(e.target.value)}
             onKeyPress={handleKeyPress}
             disabled={isBotTyping}
           />

frontend_service/vite.config.ts

@@ -3,7 +3,7 @@ import tailwindcss from "@tailwindcss/vite";
 import { defineConfig } from "vite";
 import tsconfigPaths from "vite-tsconfig-paths";
 
-export default defineConfig({
+export default defineConfig(({ mode }: { mode: string }) => ({
   plugins: [tailwindcss(), reactRouter({
     // FIX: Add historyApiFallback to ensure deep links (like /dashboard) fall back to index.html
     historyApiFallback: {
@@ -18,5 +18,19 @@ export default defineConfig({
       clientPort: 3000
     },
     allowedHosts: ['relibank.westus2.cloudapp.azure.com'],
+    // Only use proxy in development mode (local machine)
+    // In production, the ingress handles routing to backend services
+    ...(mode === 'development' && {
+      proxy: {
+        '/chatbot-service': {
+          target: 'http://chatbot-service:5003',
+          changeOrigin: true
+        },
+        '/bill-pay-service': {
+          target: 'http://bill-pay-service:5000',
+          changeOrigin: true
+        }
+      }
+    })
   },
-});
+}));

k8s/base/databases/mssql-deployment.yaml

@@ -38,16 +38,16 @@ spec:
               name: database-credentials
               key: MSSQL_SA_PASSWORD
         - name: MSSQL_MEMORY_LIMIT_MB
-          value: "3072"
+          value: "1024"
         - name: MSSQL_PID
           value: "Developer"
         resources:
           requests:
-            memory: "4Gi"
-            cpu: "2000m"
+            memory: "1Gi"
+            cpu: "500m"
           limits:
-            memory: "4Gi"
-            cpu: "2000m"
+            memory: "2Gi"
+            cpu: "1000m"
         volumeMounts:
         - name: mssql
           mountPath: "/var/opt/mssql"