Merge pull request #28 from newrelic/develop

fix: timeSinceLastError and timeSinceLastAdError added

Author: rajeevkumar-nr

DATAMODEL.md

@@ -63,6 +63,7 @@ An Attribute is a piece of data associated with an event. Attributes provide add
 | totalAdPlaytime          | Total time ad is played for this video session.                                                                                                    |
 | elapsedTime              | Active time video watched between two consecutive heartbeats                                                                                       |
 | bufferType               | When buffer starts, i.e., initial, seek, pause & connection.                                                                                       |
+| timeSinceLastError       | Time in milliseconds since the last content error occurred. Only included after an error has occurred.                                             |
 | asn                      | Autonomous System Number: a unique number identifying a group of IP networks that serves the content to the end user.                              |
 | asnLatitude              | The latitude of the geographic center of the postal code where the Autonomous System Network is registered. This is not the end user's latitude.   |
 | asnLongitude             | The longitude of the geographic center of the postal code where the Autonomous System Network is registered. This is not the end user's longitude. |
@@ -125,6 +126,7 @@ An Attribute is a piece of data associated with an event. Attributes provide add
 | adPartner                | The ad partner, e.g., ima, freewheel.                                                                                                              |
 | isBackgroundEvent        | If the player is hidden by another window.                                                                                                         |
 | bufferType               | When buffer starts, i.e., initial, seek, pause & connection.                                                                                       |
+| timeSinceLastAdError     | Time in milliseconds since the last ad error occurred. Only included after an ad error has occurred.                                               |
 | asn                      | Autonomous System Number: a unique number identifying a group of IP networks that serves the content to the end user.                              |
 | asnLatitude              | The latitude of the geographic center of the postal code where the Autonomous System Network is registered. This is not the end user's latitude.   |
 | asnLongitude             | The longitude of the geographic center of the postal code where the Autonomous System Network is registered. This is not the end user's longitude. |

src/tracker.js

@@ -170,20 +170,34 @@ export default class DashTracker extends nrvideo.VideoTracker {
       'qualityChangeRendered',
     ]);
 
-    this.player.on('streamInitialized', this.onReady.bind(this));
-    this.player.on('playbackMetaDataLoaded', this.onDownload.bind(this));
-    this.player.on('playbackLoadedData', this.onDownload.bind(this));
-    this.player.on('canPlay', this.onPlay.bind(this));
-    this.player.on('playbackPlaying', this.onPlaying.bind(this));
-    this.player.on('playbackPaused', this.onPause.bind(this));
-    this.player.on('playbackSeeking', this.onSeeking.bind(this));
-    this.player.on('playbackSeeked', this.onSeeked.bind(this));
-    this.player.on('error', this.onError.bind(this));
-    this.player.on('playbackError', this.onError.bind(this));
-    this.player.on('playbackEnded', this.onEnded.bind(this));
-    this.player.on('bufferStalled', this.onBufferingStalled.bind(this));
-    this.player.on('bufferLoaded', this.onBufferingLoaded.bind(this));
-    this.player.on('qualityChangeRendered', this.onAdaptation.bind(this));
+    // BIND LISTENER METHODS
+    this.onReady = this.onReady.bind(this);
+    this.onDownload = this.onDownload.bind(this);
+    this.onPlay = this.onPlay.bind(this);
+    this.onPlaying = this.onPlaying.bind(this);
+    this.onPause = this.onPause.bind(this);
+    this.onSeeking = this.onSeeking.bind(this);
+    this.onSeeked = this.onSeeked.bind(this);
+    this.onError = this.onError.bind(this);
+    this.onEnded = this.onEnded.bind(this);
+    this.onBufferingStalled = this.onBufferingStalled.bind(this);
+    this.onBufferingLoaded = this.onBufferingLoaded.bind(this);
+    this.onAdaptation = this.onAdaptation.bind(this);
+
+    this.player.on('streamInitialized', this.onReady);
+    this.player.on('playbackMetaDataLoaded', this.onDownload);
+    this.player.on('playbackLoadedData', this.onDownload);
+    this.player.on('canPlay', this.onPlay);
+    this.player.on('playbackPlaying', this.onPlaying);
+    this.player.on('playbackPaused', this.onPause);
+    this.player.on('playbackSeeking', this.onSeeking);
+    this.player.on('playbackSeeked', this.onSeeked);
+    this.player.on('error', this.onError);
+    this.player.on('playbackError', this.onError);
+    this.player.on('playbackEnded', this.onEnded);
+    this.player.on('bufferStalled', this.onBufferingStalled);
+    this.player.on('bufferLoaded', this.onBufferingLoaded);
+    this.player.on('qualityChangeRendered', this.onAdaptation);
   }
 
   unregisterListeners() {