Fix undefined providerId#12947
Merged
ThangHuuVu merged 9 commits intonextauthjs:mainfrom May 18, 2025
Merged
Conversation
Client-side auth with no `providerId` param results in error.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@Regloom is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
thanks for the fix, could you add a test for it? |
Contributor
Author
|
Ok, tests added. |
ThangHuuVu
approved these changes
May 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12947 +/- ##
=======================================
Coverage 39.18% 39.19%
=======================================
Files 200 200
Lines 31612 31615 +3
Branches 1374 1381 +7
=======================================
+ Hits 12388 12391 +3
Misses 19224 19224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Client-side auth with no
providerIdparam results in error. Sample code:It's caused by parseActionAndProviderId function which returns providerId = "undefined" (as a string). This breaks the following check auth/core/src/lib/utils/providers.ts
🧢 Checklist
🎫 Affected issues
📌 Resources