fix(core): resolve signin URL correctly on error page#13379
Open
kaigritun wants to merge 1 commit intonextauthjs:mainfrom
Open
fix(core): resolve signin URL correctly on error page#13379kaigritun wants to merge 1 commit intonextauthjs:mainfrom
kaigritun wants to merge 1 commit intonextauthjs:mainfrom
Conversation
Previously, the signin link on the error page was constructed by string concatenation, resulting in malformed URLs like: /auth/error?error=AccessDenied/signin This fix uses the URL constructor to properly resolve the signin path relative to the base URL. Closes nextauthjs#13204
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Someone is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13204
The signin link on the error page was incorrectly constructed using string concatenation:
When the URL is
/auth/error?error=AccessDenied, this results in the malformed URL:/auth/error?error=AccessDenied/signinChanges
Changed to use the
URLconstructor to properly resolve the signin path:This correctly produces
/auth/signinregardless of query parameters in the current URL.Testing
Added test case in
pages.test.tsto verify the signin link is generated correctly on the error page.