Skip to content

Solid-start framework is importing types from "next-auth/react" #8301

Closed
@tsdevau

Description

@tsdevau

Environment

System:
OS: macOS 13.5
CPU: (10) arm64 Apple M1 Pro
Memory: 237.02 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.17.1 - ~/.config/nvm/versions/node/v18.17.1/bin/node
Yarn: 1.22.19 - ~/.config/nvm/versions/node/v18.17.1/bin/yarn
npm: 9.6.7 - ~/.config/nvm/versions/node/v18.17.1/bin/npm
pnpm: 8.6.12 - ~/.config/nvm/versions/node/v18.17.1/bin/pnpm
Browsers:
Brave Browser: 115.1.56.20
Chrome: 114.0.5735.198
Edge: 115.0.1901.203
Safari: 16.6

Reproduction URL

https://github.com/nextauthjs/next-auth/blob/main/packages/frameworks-solid-start/src/client.ts

Describe the issue

Framework for solid-start is attempting to import the following types from next-auth/react which is not included as a dependency (or otherwise required) for the solid-start framework.

import { LiteralUnion, SignInOptions, SignInAuthorizationParams, SignOutParams } from 'next-auth/react';

I suspect this is related to the issue I'm having where a redirect included in a signOut({ callbackUrl: "/", redirect: true }) call does not occur.

How to reproduce

Refer to the client.ts file in the next-auth repo.

Screenshot 2023-08-12 at 08 43 19

Expected behavior

The required interfaces should be declared and exported from @auth/core or @auth/solid-start . Then imports should reference the interfaces/types from those included within @auth/core or @auth/solid-start.

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageUnseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions