improve storage permission ui ux

Signed-off-by: alperozturk <[email protected]>

Author: alperozturk96

app/src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.kt

@@ -38,9 +38,11 @@ import com.nextcloud.client.jobs.upload.FileUploadWorker
 import com.nextcloud.client.preferences.SubFolderRule
 import com.nextcloud.utils.extensions.getParcelableArgument
 import com.nextcloud.utils.extensions.isDialogFragmentReady
+import com.nextcloud.utils.extensions.setVisibleIf
 import com.owncloud.android.BuildConfig
 import com.owncloud.android.MainApp
 import com.owncloud.android.R
+import com.owncloud.android.databinding.StoragePermissionWarningBannerBinding
 import com.owncloud.android.databinding.SyncedFoldersLayoutBinding
 import com.owncloud.android.datamodel.ArbitraryDataProviderImpl
 import com.owncloud.android.datamodel.MediaFolder
@@ -53,6 +55,7 @@ import com.owncloud.android.datamodel.SyncedFolderProvider
 import com.owncloud.android.files.services.NameCollisionPolicy
 import com.owncloud.android.lib.common.utils.Log_OC
 import com.owncloud.android.ui.adapter.SyncedFolderAdapter
+import com.owncloud.android.ui.adapter.storagePermissionBanner.setup
 import com.owncloud.android.ui.decoration.MediaGridItemDecoration
 import com.owncloud.android.ui.dialog.ConfirmationDialogFragment
 import com.owncloud.android.ui.dialog.SyncedFolderPreferencesDialogFragment
@@ -66,7 +69,6 @@ import kotlinx.coroutines.withContext
 import java.io.File
 import java.util.Locale
 import javax.inject.Inject
-import com.nextcloud.utils.extensions.setVisibleIf
 
 /**
  * Activity displaying all auto-synced folders and/or instant upload media folders.
@@ -198,14 +200,20 @@ class SyncedFoldersActivity :
             setTheme(R.style.FallbackThemingTheme)
         }
         binding.emptyList.emptyListViewAction.setOnClickListener { showHiddenItems() }
-        binding.storagePermissionWarningBanner.root.setVisibleIf(shouldShowStoragePermissionWarningBanner())
+        setupStoragePermissionWarningBanner()
     }
 
-    private fun shouldShowStoragePermissionWarningBanner(): Boolean {
-        return !PermissionUtil.checkStoragePermission(this)
-            && preferences.showStoragePermissionBanner()
+    private fun setupStoragePermissionWarningBanner() {
+        val storagePermissionWarningBanner = binding.storagePermissionWarningBanner.root
+        StoragePermissionWarningBannerBinding.bind(storagePermissionWarningBanner).apply {
+            setup(appPreferences)
+        }
+        storagePermissionWarningBanner.setVisibleIf(shouldShowStoragePermissionWarningBanner())
     }
 
+    private fun shouldShowStoragePermissionWarningBanner(): Boolean = !PermissionUtil.checkStoragePermission(this) &&
+        preferences.showStoragePermissionBanner()
+
     override fun onCreateOptionsMenu(menu: Menu): Boolean {
         val inflater = menuInflater
         inflater.inflate(R.menu.activity_synced_folders, menu)

app/src/main/java/com/owncloud/android/ui/adapter/storagePermissionBanner/StoragePermissionBannerActionHandler.kt

@@ -0,0 +1,36 @@
+/*
+ * Nextcloud - Android Client
+ *
+ * SPDX-FileCopyrightText: 2025 Alper Ozturk <[email protected]>
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+package com.owncloud.android.ui.adapter.storagePermissionBanner
+
+import android.view.View
+import com.nextcloud.client.preferences.AppPreferences
+import com.nextcloud.utils.extensions.openAllFilesAccessSettings
+import com.nextcloud.utils.extensions.openMediaPermissions
+import com.nextcloud.utils.extensions.setVisibleIf
+import com.owncloud.android.databinding.StoragePermissionWarningBannerBinding
+import com.owncloud.android.utils.PermissionUtil
+
+fun StoragePermissionWarningBannerBinding.setup(appPreferences: AppPreferences) {
+    val context = this.root.context
+
+    fullFileAccess.setVisibleIf(!PermissionUtil.checkFullFileAccess())
+    fullFileAccess.setOnClickListener { context.openAllFilesAccessSettings() }
+
+    mediaReadOnly.setVisibleIf(!PermissionUtil.checkMediaAccess(context))
+    mediaReadOnly.setOnClickListener { context.openMediaPermissions() }
+
+    dontShowStoragePermissionBanner.setOnClickListener {
+        root.visibility = View.GONE
+        appPreferences.setShowStoragePermissionBanner(false)
+    }
+
+    root.visibility = if (PermissionUtil.checkFullFileAccess() || PermissionUtil.checkMediaAccess(context)) {
+        View.GONE
+    } else {
+        View.VISIBLE
+    }
+}

app/src/main/java/com/owncloud/android/ui/adapter/storagePermissionBanner/StoragePermissionBannerViewHolder.kt

@@ -9,43 +9,14 @@ package com.owncloud.android.ui.adapter.storagePermissionBanner
 
 import android.view.View
 import androidx.recyclerview.widget.RecyclerView
-import com.google.android.material.button.MaterialButton
 import com.nextcloud.client.preferences.AppPreferences
-import com.nextcloud.utils.extensions.openAllFilesAccessSettings
-import com.nextcloud.utils.extensions.openMediaPermissions
-import com.nextcloud.utils.extensions.setVisibleIf
-import com.owncloud.android.R
-import com.owncloud.android.utils.PermissionUtil
+import com.owncloud.android.databinding.StoragePermissionWarningBannerBinding
 
 class StoragePermissionBannerViewHolder(itemView: View, private val appPreferences: AppPreferences) :
     RecyclerView.ViewHolder(itemView) {
-
-    private val fullFileAccessButton: MaterialButton =
-        itemView.findViewById(R.id.fullFileAccess)
-    private val mediaAccessButton: MaterialButton =
-        itemView.findViewById(R.id.mediaReadOnly)
-    private val dismissButton: MaterialButton =
-        itemView.findViewById(R.id.dontShowStoragePermissionBanner)
-
     init {
-        val context = itemView.context
-
-        fullFileAccessButton.setVisibleIf(!PermissionUtil.checkFullFileAccess())
-        fullFileAccessButton.setOnClickListener {
-            context.openAllFilesAccessSettings()
-        }
-        mediaAccessButton.setVisibleIf(!PermissionUtil.checkMediaAccess(context))
-        mediaAccessButton.setOnClickListener {
-            context.openMediaPermissions()
+        StoragePermissionWarningBannerBinding.bind(itemView).apply {
+            setup(appPreferences)
         }
-
-        dismissButton.setOnClickListener {
-            dontShowBanner()
-        }
-    }
-
-    private fun dontShowBanner() {
-        itemView.visibility = View.GONE
-        appPreferences.setShowStoragePermissionBanner(false)
     }
 }

app/src/main/res/layout/synced_folders_layout.xml

@@ -36,6 +36,7 @@
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:visibility="gone"
+                android:layout_marginTop="@dimen/standard_margin"
                 android:layout_marginHorizontal="@dimen/standard_margin"
                 tools:visibility="visible" />