Skip to content

Commit cb137eb

Browse files
Merge pull request #14405 from nextcloud/dont-ask-ACCESS_MEDIA_LOCATION-permission-if-device-have-full-disk-access
Don't Ask ACCESS_MEDIA_LOCATION Permission If App Already Has Full Disk Access
2 parents 0abff31 + 5c8f4b1 commit cb137eb

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

app/src/main/java/com/owncloud/android/utils/PermissionUtil.kt

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -313,14 +313,22 @@ object PermissionUtil {
313313
*/
314314
@JvmStatic
315315
fun requestMediaLocationPermission(activity: Activity) {
316-
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
317-
if (!checkSelfPermission(activity, Manifest.permission.ACCESS_MEDIA_LOCATION)) {
318-
ActivityCompat.requestPermissions(
319-
activity,
320-
arrayOf(Manifest.permission.ACCESS_MEDIA_LOCATION),
321-
PERMISSIONS_MEDIA_LOCATION
322-
)
323-
}
316+
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
317+
return
318+
}
319+
320+
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R && Environment.isExternalStorageManager()) {
321+
return
324322
}
323+
324+
if (checkSelfPermission(activity, Manifest.permission.ACCESS_MEDIA_LOCATION)) {
325+
return
326+
}
327+
328+
ActivityCompat.requestPermissions(
329+
activity,
330+
arrayOf(Manifest.permission.ACCESS_MEDIA_LOCATION),
331+
PERMISSIONS_MEDIA_LOCATION
332+
)
325333
}
326334
}

0 commit comments

Comments
 (0)