Skip to content

Commit fa32f76

Browse files
committed
fix(landingpage): replace editor heading with a thin line
The heading "landing page" caused confusions, took unnecessary space and made the layout even more complex. Signed-off-by: Jonas <jonas@freesources.org>
1 parent e618282 commit fa32f76

3 files changed

Lines changed: 1 addition & 19 deletions

File tree

src/components/Page/LandingPageWidgets.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ export default {
6262
<style scoped>
6363
.landing-page-widgets {
6464
padding-inline: 14px 8px;
65+
border-bottom: 1px solid var(--border-color);
6566
}
6667
.first-row-widgets{
6768
display: flex;

src/components/Page/TextEditor.vue

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55

66
<template>
77
<div ref="textContainer" class="collectives-text-container">
8-
<WidgetHeading v-if="isLandingPage"
9-
:title="t('collectives', 'Landing page')"
10-
class="text-container-heading" />
118
<SkeletonLoading v-show="!contentLoaded"
129
type="text"
1310
class="page-content-skeleton" />
@@ -26,7 +23,6 @@ import { ref, watch } from 'vue'
2623
import { useElementSize } from '@vueuse/core'
2724
import { subscribe, unsubscribe } from '@nextcloud/event-bus'
2825
import { showError } from '@nextcloud/dialogs'
29-
import WidgetHeading from './LandingPageWidgets/WidgetHeading.vue'
3026
import { mapActions, mapState } from 'pinia'
3127
import { useRootStore } from '../../stores/root.js'
3228
import { useCollectivesStore } from '../../stores/collectives.js'
@@ -42,7 +38,6 @@ export default {
4238
4339
components: {
4440
SkeletonLoading,
45-
WidgetHeading,
4641
},
4742
4843
mixins: [
@@ -74,7 +69,6 @@ export default {
7469
...mapState(usePagesStore, [
7570
'currentPage',
7671
'currentPageDavUrl',
77-
'isLandingPage',
7872
'isTemplatePage',
7973
]),
8074
@@ -214,20 +208,12 @@ export default {
214208
min-height: 50vh;
215209
}
216210
217-
.text-container-heading {
218-
padding-inline: 14px 8px;
219-
}
220-
221211
.page-content-skeleton {
222212
padding-block-start: var(--default-clickable-area);
223213
}
224214
225215
@media print {
226216
/* Don't print unwanted elements */
227-
.text-container-heading {
228-
display: none !important;
229-
}
230-
231217
.collectives-text-container {
232218
overflow: visible;
233219
}

src/css/editor.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@
3939
margin-inline: auto;
4040
}
4141

42-
.text-container-heading {
43-
max-width: min(var(--text-editor-max-width), 100%);
44-
margin-inline: auto;
45-
}
46-
4742
.page-title {
4843
max-width: 100%;
4944
margin: 0 0 0 max(0px, calc(50% - (var(--text-editor-max-width) / 2)));

0 commit comments

Comments
 (0)